Revise internal/db/storage/s3 tests in #837

[rinx]

Signed-off-by: Rintaro Okamura [email protected]

Description:

revise #837.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

• Go Version: 1.15.2
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.1

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #848 (2ca5379) into test/internal/add_s3_test (250df9c) will decrease coverage by 0.61%.
The diff coverage is 100.00%.

@@                      Coverage Diff                      @@
##           test/internal/add_s3_test     #848      +/-   ##
=============================================================
- Coverage                      18.12%   17.51%   -0.62%     
=============================================================
  Files                            423      421       -2     
  Lines                          19574    19508      -66     
=============================================================
- Hits                            3547     3416     -131     
- Misses                         15811    15883      +72     
+ Partials                         216      209       -7     

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/option.go	100.00% <ø> (+29.09%)	⬆️
internal/db/storage/blob/s3/s3.go	93.10% <100.00%> (-6.90%)	⬇️
internal/db/nosql/cassandra/cassandra.go	0.00% <0.00%> (-97.44%)	⬇️
internal/worker/worker.go	82.29% <0.00%> (ø)
internal/db/nosql/cassandra/cassandra_mock.go
internal/net/net.go
internal/db/storage/blob/s3/reader/reader.go	97.72% <0.00%> (+31.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250df9c...c3e28c1. Read the comment docs.