Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade KinD, Helm, valdcli, telepresence, tensorlfow, operator-sdk, … #776

Merged
merged 1 commit into from
Oct 14, 2020
Merged

upgrade KinD, Helm, valdcli, telepresence, tensorlfow, operator-sdk, … #776

merged 1 commit into from
Oct 14, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Oct 14, 2020

…helm-docs

Description:

upgrade tools.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx rinx requested a review from datelier October 14, 2020 05:33
github-actions[bot]
github-actions bot reviewed Oct 14, 2020
View reviewed changes
charts/vald-helm-operator/README.md.gotmpl
@@ -3,7 +3,7 @@ vald-helm-operator

This is a Helm chart to install vald-helm-operator.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

charts/vald-helm-operator/README.md.gotmpl
@@ -3,7 +3,7 @@ vald-helm-operator

This is a Helm chart to install vald-helm-operator.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space before the full stop (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: .
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

charts/vald-helm-operator/README.md.gotmpl
@@ -3,7 +3,7 @@ vald-helm-operator

This is a Helm chart to install vald-helm-operator.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION

charts/vald/README.md.gotmpl
@@ -3,7 +3,7 @@ Vald

This is a Helm chart to install Vald components.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

charts/vald/README.md.gotmpl
@@ -3,7 +3,7 @@ Vald

This is a Helm chart to install Vald components.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space before the full stop (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: .
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

charts/vald/README.md.gotmpl
@@ -3,7 +3,7 @@ Vald

This is a Helm chart to install Vald components.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION

@rinx rinx marked this pull request as ready for review October 14, 2020 05:53
@rinx rinx requested a review from kpango October 14, 2020 05:53
kpango
kpango reviewed Oct 14, 2020
View reviewed changes
versions/TENSORFLOW_C_VERSION
@@ -1 +1 @@
1.15.0
2.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we have a problem with tf v2.0.0~2.2.0, can we use v2.3.0 ? If we can use,it should be v2.3.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpango there's no problem. @datelier confirmed that v2.3.0 is okay.

there's no prebuilt lib of version v2.3.1 here, so it should be v2.3.0.
https://www.tensorflow.org/install/lang_c

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I understand LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kpango kpango merged commit 3b9325b into master Oct 14, 2020
@kpango kpango deleted the dependencies/tools/update-kind-helm-valdcli-telepresence-tensorflow-operator-sdk branch October 14, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kpango kpango kpango left review comments

@datelier datelier datelier approved these changes

Assignees
No one assigned
Labels
area/helm area/makefile priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rinx @vdaas-ci @kpango @datelier