[patch] change gateway vald's mutex lock #765

kpango · 2020-10-12T09:46:56Z

Signed-off-by: kpango [email protected]

Description:

replace sync.Mutex lock map using sync.Map CAS operation

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: kpango <[email protected]>

vdaas-ci · 2020-10-12T09:47:10Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

github-actions · 2020-10-12T09:52:26Z

pkg/gateway/vald/handler/grpc/handler.go

+				case pos == len(res.GetResults())-1:
+					res.Results = append(res.GetResults(), dist)
+				case pos >= 0:
+					res.Results = append(res.GetResults()[:pos+1], res.GetResults()[pos:]...)


[golangci] _{reported by reviewdog 🐶}
appendAssign: append result not assigned to the same slice (gocritic)

github-actions · 2020-10-12T09:52:27Z

pkg/gateway/vald/handler/grpc/handler.go

+						break
+					}
+				}
+				switch {


[golangci] _{reported by reviewdog 🐶}
anonymous switch statements should never be cuddled (wsl)

github-actions · 2020-10-12T09:52:27Z

pkg/gateway/vald/handler/grpc/handler.go

+				for idx := pos; idx >= 1; idx-- {
+					if res.GetResults()[idx-1].GetDistance() <= dist.GetDistance() {
+						pos = idx - 1
+						break


[golangci] _{reported by reviewdog 🐶}
break with no blank line before (nlreturn)

codecov · 2020-10-12T09:53:41Z

Codecov Report

Merging #765 into master will increase coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   16.72%   16.92%   +0.20%     
==========================================
  Files         420      421       +1     
  Lines       19476    19528      +52     
==========================================
+ Hits         3258     3306      +48     
  Misses      15997    15997              
- Partials      221      225       +4

Impacted Files	Coverage Δ
pkg/gateway/vald/handler/grpc/handler.go	`0.00% <0.00%> (ø)`
internal/net/net.go	`85.18% <0.00%> (ø)`
internal/worker/worker.go	`83.33% <0.00%> (+1.04%)`	⬆️
internal/errgroup/group.go	`93.93% <0.00%> (+1.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd738f...44d4bb3. Read the comment docs.

Signed-off-by: kpango <[email protected]>

pkg/gateway/vald/handler/grpc/handler.go

Signed-off-by: kpango <[email protected]>

pkg/gateway/vald/handler/grpc/handler.go

…duplication

kpango · 2020-10-13T02:21:54Z

@rinx @kmrmt fixed,

pkg/gateway/vald/handler/grpc/handler.go

Co-authored-by: Rintaro Okamura <[email protected]>

kpango · 2020-10-13T02:23:07Z

@rinx commit suggestion

rinx · 2020-10-13T02:23:58Z

Thanks! it became understandable code. 👍

kpango · 2020-10-13T02:24:41Z

kmrmt's review we don't need to fix it. I'll merge this PR

[patch] change gateway vald's mutex lock

e887e94

Signed-off-by: kpango <[email protected]>

github-actions bot added area/gateway size/M type/bug Something isn't working priority/medium labels Oct 12, 2020

github-actions bot reviewed Oct 12, 2020

View reviewed changes

kpango force-pushed the bugfix/gateway-vald/change-lock-block-for-duplication branch 2 times, most recently from 0060b50 to 9183b07 Compare October 13, 2020 01:49

fix

f9373fb

Signed-off-by: kpango <[email protected]>

kpango force-pushed the bugfix/gateway-vald/change-lock-block-for-duplication branch from 9183b07 to f9373fb Compare October 13, 2020 01:58

rinx suggested changes Oct 13, 2020

View reviewed changes

pkg/gateway/vald/handler/grpc/handler.go Outdated Show resolved Hide resolved

pkg/gateway/vald/handler/grpc/handler.go Outdated Show resolved Hide resolved

pkg/gateway/vald/handler/grpc/handler.go Outdated Show resolved Hide resolved

fix

0cc6113

Signed-off-by: kpango <[email protected]>

kpango force-pushed the bugfix/gateway-vald/change-lock-block-for-duplication branch from 90498a9 to 0cc6113 Compare October 13, 2020 02:18

kmrmt reviewed Oct 13, 2020

View reviewed changes

pkg/gateway/vald/handler/grpc/handler.go Show resolved Hide resolved

Merge branch 'master' into bugfix/gateway-vald/change-lock-block-for-…

7e3aa2d

…duplication

rinx reviewed Oct 13, 2020

View reviewed changes

pkg/gateway/vald/handler/grpc/handler.go Outdated Show resolved Hide resolved

Update pkg/gateway/vald/handler/grpc/handler.go

44d4bb3

Co-authored-by: Rintaro Okamura <[email protected]>

kpango merged commit ac40a15 into master Oct 13, 2020

kpango deleted the bugfix/gateway-vald/change-lock-block-for-duplication branch October 13, 2020 02:26

kpango mentioned this pull request Oct 13, 2020

bugfix/internal gateway/new design apis #767

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[patch] change gateway vald's mutex lock #765

[patch] change gateway vald's mutex lock #765

kpango commented Oct 12, 2020

vdaas-ci commented Oct 12, 2020

github-actions bot Oct 12, 2020

github-actions bot Oct 12, 2020

github-actions bot Oct 12, 2020

codecov bot commented Oct 12, 2020 •

edited

Loading

kpango commented Oct 13, 2020

kpango commented Oct 13, 2020

rinx commented Oct 13, 2020

kpango commented Oct 13, 2020 •

edited

Loading

[patch] change gateway vald's mutex lock #765

[patch] change gateway vald's mutex lock #765

Conversation

kpango commented Oct 12, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Oct 12, 2020

github-actions bot Oct 12, 2020

Choose a reason for hiding this comment

github-actions bot Oct 12, 2020

Choose a reason for hiding this comment

github-actions bot Oct 12, 2020

Choose a reason for hiding this comment

codecov bot commented Oct 12, 2020 • edited Loading

Codecov Report

kpango commented Oct 13, 2020

kpango commented Oct 13, 2020

rinx commented Oct 13, 2020

kpango commented Oct 13, 2020 • edited Loading

codecov bot commented Oct 12, 2020 •

edited

Loading

kpango commented Oct 13, 2020 •

edited

Loading