Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for s3 session option #736

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 1, 2020

Signed-off-by: hlts2 [email protected]

Description:

I added test for internal/db/storage/blob/s3/session/option.go

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: hlts2 <[email protected]>
@hlts2 hlts2 requested a review from kevindiu October 1, 2020 03:24
@hlts2 hlts2 self-assigned this Oct 1, 2020
@pull-assistant
Copy link

pull-assistant bot commented Oct 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     add test for option

     add comment

Powered by Pull Assistant. Last update 667000a ... d3977a4. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 1, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #736 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   14.64%   14.81%   +0.16%     
==========================================
  Files         419      419              
  Lines       19449    19449              
==========================================
+ Hits         2849     2881      +32     
+ Misses      16376    16343      -33     
- Partials      224      225       +1     
Impacted Files Coverage Δ
internal/db/storage/blob/s3/session/option.go 100.00% <ø> (+47.61%) ⬆️
internal/worker/worker.go 83.33% <0.00%> (+1.04%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb2dd9...d3977a4. Read the comment docs.

@kevindiu
Copy link
Contributor

kevindiu commented Oct 1, 2020

can you write doc for option.go?

Signed-off-by: hlts2 <[email protected]>
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi October 1, 2020 05:26
@vankichi
Copy link
Contributor

vankichi commented Oct 1, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 1, 2020

[REBASE] Rebase triggered by vankichi for branch: internal/test/add-s3-session-option

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 1d4b780 into master Oct 1, 2020
@vankichi vankichi deleted the internal/test/add-s3-session-option branch October 1, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants