-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for s3 session option #736
Conversation
Signed-off-by: hlts2 <[email protected]>
Best reviewed: commit by commit
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 14.64% 14.81% +0.16%
==========================================
Files 419 419
Lines 19449 19449
==========================================
+ Hits 2849 2881 +32
+ Misses 16376 16343 -33
- Partials 224 225 +1
Continue to review full report at Codecov.
|
can you write doc for option.go? |
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: internal/test/add-s3-session-option |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: hlts2 [email protected]
Description:
I added test for
internal/db/storage/blob/s3/session/option.go
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: