Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AVX2 to Requirements #686

Merged
merged 1 commit into from
Sep 14, 2020
Merged

add AVX2 to Requirements #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ Go to [Get Started](./docs/tutorial/get-started.md) page to try out Vald :)
- gRPC APIs can be triggered by any programming languages which support gRPC.
- REST API is also supported.```

## Requirement
## Requirements

kubernetes 1.17~
- Kubernetes 1.17~
- AVX2 instructions (required by Vald Agent NGT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the following question.

  1. Does X86 supported?
  2. ARM CPU supported?
  3. Only AVX2 is required? other AVX instruction is required?
Suggested change
- AVX2 instructions (required by Vald Agent NGT)
- X64 CPU with AVX2 instructions set supported (required by Vald Agent NGT)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 and 2 ... currently, we don't provide docker images for these CPU architectures.
however, we are planning to provide docker images for each of them in the near future.

3 ... i'm not sure but maybe only AVX2 is needed. @kpango do you know about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW not sure if AVX is required or optional 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, AVX2 is required, but once the issue #687 is resolved, it becomes optional.


## Get Started

Expand Down