Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contributing guide #678

Merged
merged 4 commits into from
Sep 14, 2020
Merged

update contributing guide #678

merged 4 commits into from
Sep 14, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Sep 7, 2020

Signed-off-by: vankichi [email protected]

Description:

Update branch naming rule and add code blocking.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.1
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi vankichi requested review from a team, kmrmt and hlts2 and removed request for a team September 7, 2020 10:02
@pull-assistant
Copy link

pull-assistant bot commented Sep 7, 2020 •
edited
Loading

Score: 0.82

Best reviewed: commit by commit

Optimal code review plan

     📝 update contributing guide

     📝 fix

     📝 fix

     📝 fix

Powered by Pull Assistant. Last update 2ba631e ... 921790e. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 7, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@vankichi vankichi requested review from kevindiu and removed request for kmrmt September 7, 2020 10:03
github-actions[bot]
github-actions bot reviewed Sep 7, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
hlts2
hlts2 reviewed Sep 7, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 9, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
kevindiu
kevindiu suggested changes Sep 9, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
kevindiu
kevindiu reviewed Sep 9, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kevindiu
kevindiu reviewed Sep 9, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
hlts2
hlts2 previously approved these changes Sep 10, 2020
View reviewed changes
kevindiu
kevindiu previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentation/contributing/update-branchbnaming-rules

@vdaas-ci vdaas-ci dismissed stale reviews from kevindiu and hlts2 via 36db2c0 September 10, 2020 02:12
@vdaas-ci vdaas-ci force-pushed the documentation/contributing/update-branchbnaming-rules branch from f7b02c4 to 36db2c0 Compare September 10, 2020 02:12
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentation/contributing/update-branchbnaming-rules

@vdaas-ci vdaas-ci force-pushed the documentation/contributing/update-branchbnaming-rules branch from 36db2c0 to 5dc0fd7 Compare September 10, 2020 09:22
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentation/contributing/update-branchbnaming-rules

@vankichi @actions-user
📝 update contributing guide
2ba631e 
Signed-off-by: vankichi <[email protected]>
@vankichi @actions-user
📝 fix
314220e 
Signed-off-by: vankichi <[email protected]>
@vankichi @actions-user
📝 fix
0d55f14 
Signed-off-by: vankichi <[email protected]>
@vankichi @actions-user
📝 fix
921790e 
Signed-off-by: vankichi <[email protected]>
@vdaas-ci vdaas-ci force-pushed the documentation/contributing/update-branchbnaming-rules branch from 5dc0fd7 to 921790e Compare September 11, 2020 06:37
@vankichi vankichi merged commit 0c32f9d into master Sep 14, 2020
@vankichi vankichi deleted the documentation/contributing/update-branchbnaming-rules branch September 14, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kpango kpango kpango left review comments

@vdaas-ci vdaas-ci vdaas-ci left review comments

@hlts2 hlts2 hlts2 left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees
No one assigned
Labels
priority/low size/S type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vankichi @vdaas-ci @kevindiu @kpango @hlts2