Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test #671

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix failing test #671

merged 1 commit into from
Sep 4, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Sep 3, 2020

Signed-off-by: hlts2 [email protected]

Description:

I fixed the failing tests.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.1
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2 hlts2 requested a review from kevindiu September 3, 2020 06:09
@pull-assistant
Copy link

pull-assistant bot commented Sep 3, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: failing tset

Powered by Pull Assistant. Last update ae03a7a ... ae03a7a. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #671 into master will increase coverage by 0.11%.
The diff coverage is 3.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   15.13%   15.24%   +0.11%     
==========================================
  Files         411      411              
  Lines       21537    21578      +41     
==========================================
+ Hits         3259     3289      +30     
- Misses      18024    18038      +14     
+ Partials      254      251       -3     
Impacted Files Coverage Δ
internal/observability/metrics/metrics.go 0.00% <ø> (ø)
pkg/agent/sidecar/service/observer/observer.go 0.00% <0.00%> (ø)
pkg/agent/sidecar/service/observer/option.go 9.80% <0.00%> (-1.83%) ⬇️
pkg/agent/sidecar/service/storage/storage.go 0.00% <0.00%> (ø)
pkg/agent/sidecar/usecase/sidecar/sidecar.go 0.00% <0.00%> (ø)
pkg/manager/index/service/indexer.go 0.00% <ø> (ø)
pkg/manager/index/usecase/indexer.go 0.00% <0.00%> (ø)
internal/compress/gob.go 100.00% <100.00%> (+72.09%) ⬆️
internal/errgroup/group.go 94.73% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033c2a6...ae03a7a. Read the comment docs.

kevindiu
kevindiu previously approved these changes Sep 3, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi September 3, 2020 06:29
@hlts2 hlts2 self-assigned this Sep 3, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov 😕

vankichi
vankichi previously approved these changes Sep 3, 2020
@vankichi
Copy link
Contributor

vankichi commented Sep 3, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 3, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/failing_test

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via ae03a7a September 3, 2020 08:38
@vdaas-ci vdaas-ci force-pushed the test/internal/failing_test branch from 1604bc9 to ae03a7a Compare September 3, 2020 08:38
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 3, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 1e0c37e into master Sep 4, 2020
@vankichi vankichi deleted the test/internal/failing_test branch September 4, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants