Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for internal/compress/gob.go #646

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Aug 27, 2020

Description:

I added test case for internal/compress/gob.go and I refactored based on code guideline.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 27, 2020

Score: 0.95

Best reviewed: commit by commit


Optimal code review plan

     feat: add test case

     feat: add test case

     feat: add e2e test

     feat: typo

     feat: lint warning

     fix: apply suggestion

Powered by Pull Assistant. Last update 64d6d50 ... 30f9700. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #646 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   15.13%   15.26%   +0.13%     
==========================================
  Files         411      411              
  Lines       21537    21535       -2     
==========================================
+ Hits         3259     3288      +29     
+ Misses      18024    17996      -28     
+ Partials      254      251       -3     
Impacted Files Coverage Δ
internal/compress/gob.go 100.00% <100.00%> (+72.09%) ⬆️
internal/worker/queue.go 95.65% <0.00%> (-2.90%) ⬇️
internal/worker/worker.go 85.45% <0.00%> (+0.90%) ⬆️
internal/errgroup/group.go 94.73% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a0b9e...30f9700. Read the comment docs.

internal/compress/gob_test.go Show resolved Hide resolved
internal/compress/gob_test.go Outdated Show resolved Hide resolved
internal/compress/gob.go Outdated Show resolved Hide resolved
internal/compress/gob.go Outdated Show resolved Hide resolved
kevindiu
kevindiu previously approved these changes Aug 27, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi August 27, 2020 08:31
vankichi
vankichi previously approved these changes Aug 31, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/gob

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via 30f9700 August 31, 2020 02:12
@vdaas-ci vdaas-ci force-pushed the test/internal/compress/gob branch from 1ebd8cd to 30f9700 Compare August 31, 2020 02:12
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit de83272 into master Aug 31, 2020
@vankichi vankichi deleted the test/internal/compress/gob branch August 31, 2020 05:25
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants