Add test case for s3/option.go

[hlts2]

Signed-off-by: hlts2 [email protected]

Description:

I added test cases and refactored the WithReaderBackoffOpts of option.go.

Refactor Content

• when opts equals nil, I fixed not to set nil. related
• Add empty checking of FOP

=> author review required

Related Ticket:

• https://github.com/vdaas/vald/projects/3#card-43770009

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     feat: add test case for option

     Update internal/db/storage/blob/s3/option_test.go

     Update internal/db/storage/blob/s3/option_test.go

     Update internal/db/storage/blob/s3/option_test.go

     fix: apply suggestion

     fix: refactor and test

     feat: add comment

Powered by Pull Assistant. Last update 827bbca ... fbf5ab6. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #640 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   14.78%   14.97%   +0.18%     
==========================================
  Files         411      411              
  Lines       21532    21536       +4     
==========================================
+ Hits         3183     3224      +41     
+ Misses      18087    18050      -37     
  Partials      262      262              

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/option.go	100.00% <100.00%> (+97.50%)	⬆️
internal/worker/queue.go	98.55% <0.00%> (-1.45%)	⬇️
internal/worker/worker.go	84.54% <0.00%> (-0.91%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d02c4e...fbf5ab6. Read the comment docs.

[kevindiu]

LGTM

[kevindiu]

LGTM

[vankichi]

LGTM

[kpango]

LGTM