-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal/worker testing fail #616
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 12.94% 13.72% +0.77%
==========================================
Files 405 409 +4
Lines 21294 21516 +222
==========================================
+ Hits 2757 2953 +196
- Misses 18264 18284 +20
- Partials 273 279 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: fix/internal/worker/ci |
fa08692
to
ead3df2
Compare
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Description:
This PR fix the internal/worker package testing fail due to the same var named in the same package.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: