Refactoring `internal/db/kvs/redis` package #590

hlts2 · 2020-07-21T02:51:43Z

Description:

I refactored internal/db/kvs/redis package. Because I can not add test.
In this PR contains changes of core logic and test.
I fixed the logic with author, so I think the merge is fine without confirmation of author.

Related Card:

https://github.com/vdaas/vald/projects/3#card-42173491

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-21T02:51:46Z

Best reviewed: commit by commit

Optimal code review plan (3 warnings)

fix: refactoring

...nternal/db/kvs/redis/option.go 62% changes removed in fix: feedback of aut...

fix: apply gotests

...nal/db/kvs/redis/redis_test.go 73% changes removed in fix: feedback of aut...

feat: test code

...nternal/db/kvs/redis/option.go 67% changes removed in fix: feedback of aut...

...nal/db/kvs/redis/redis_test.go 45% changes removed in fix: feedback of aut...

fix: feedback of author

fix: apply suggestion

🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update 0b721b9 ... 11417fc. Read the comment docs.

vdaas-ci · 2020-07-21T02:52:00Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

codecov · 2020-07-21T06:40:06Z

Codecov Report

Merging #590 into master will increase coverage by 4.36%.
The diff coverage is 28.33%.

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage    7.84%   12.21%   +4.36%     
==========================================
  Files         388      407      +19     
  Lines       19945    21236    +1291     
==========================================
+ Hits         1565     2594    +1029     
- Misses      18156    18360     +204     
- Partials      224      282      +58

Impacted Files	Coverage Δ
internal/cache/cacher/cacher.go	`100.00% <ø> (+100.00%)`	⬆️
internal/client/discoverer/discover.go	`0.00% <0.00%> (ø)`
internal/compress/gob.go	`26.19% <0.00%> (-1.31%)`	⬇️
internal/compress/gzip.go	`26.98% <0.00%> (-7.02%)`	⬇️
internal/compress/lz4.go	`36.36% <0.00%> (-5.31%)`	⬇️
internal/compress/zstd.go	`29.50% <0.00%> (-5.79%)`	⬇️
internal/config/blob.go	`0.00% <0.00%> (ø)`
internal/config/config.go	`15.78% <ø> (+15.78%)`	⬆️
internal/config/grpc.go	`0.00% <0.00%> (ø)`
internal/config/log.go	`100.00% <ø> (+100.00%)`	⬆️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8eb92...11417fc. Read the comment docs.

internal/db/kvs/redis/redis_test.go

kevindiu · 2020-07-28T09:28:35Z

/rebase

vdaas-ci · 2020-07-28T09:29:10Z

[REBASE] Rebase triggered by kevindiu for branch: refactoring/internal/redis

github-actions · 2020-07-28T09:36:08Z

internal/db/kvs/redis/redis_test.go

+	type args struct {
+		ctx context.Context
+	}
+	type fields struct {


[golangci] _{reported by reviewdog 🐶}
struct of size 240 bytes could be of size 232 bytes (maligned)

kevindiu · 2020-07-28T10:28:24Z

LGTM

kevindiu

LGTM

vankichi

LGTM

internal/db/kvs/redis/redis.go

vankichi · 2020-07-30T04:45:39Z

@hlts2 when you fix, I'll merge it.

hlts2 · 2020-07-30T06:15:02Z

/rebase

vdaas-ci · 2020-07-30T06:15:39Z

[REBASE] Rebase triggered by hlts2 for branch: refactoring/internal/redis

Signed-off-by: hlts2 <[email protected]>

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-07-30T06:37:59Z

/rebase
/format
/approve

vdaas-ci · 2020-07-30T06:38:36Z

[REBASE] Rebase triggered by vankichi for branch: refactoring/internal/redis

vdaas-ci · 2020-07-30T06:39:25Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team size/L type/refactoring priority/low labels Jul 21, 2020

github-actions bot added size/XL and removed size/L labels Jul 21, 2020

hlts2 changed the title ~~[WIP] Refactoring internal/db/kvs/redis package~~ Refactoring internal/db/kvs/redis package Jul 21, 2020

github-actions bot reviewed Jul 21, 2020

View reviewed changes

internal/db/kvs/redis/redis_test.go Show resolved Hide resolved

github-actions bot reviewed Jul 27, 2020

View reviewed changes

internal/db/kvs/redis/redis_test.go Show resolved Hide resolved

internal/db/kvs/redis/redis_test.go Show resolved Hide resolved

vdaas-ci force-pushed the refactoring/internal/redis branch from e021cf1 to cc032ed Compare July 28, 2020 09:29

github-actions bot reviewed Jul 28, 2020

View reviewed changes

kevindiu previously approved these changes Jul 28, 2020

View reviewed changes

hlts2 requested a review from vankichi July 28, 2020 10:31

vankichi previously approved these changes Jul 29, 2020

View reviewed changes

vankichi reviewed Jul 30, 2020

View reviewed changes

internal/db/kvs/redis/redis.go Outdated Show resolved Hide resolved

internal/db/kvs/redis/redis.go Outdated Show resolved Hide resolved

hlts2 added 4 commits July 30, 2020 06:15

fix: refactoring

0b721b9

Signed-off-by: hlts2 <[email protected]>

fix: apply gotests

959c564

Signed-off-by: hlts2 <[email protected]>

feat: test code

22271bd

Signed-off-by: hlts2 <[email protected]>

fix: feedback of author

a7934a4

Signed-off-by: hlts2 <[email protected]>

vdaas-ci dismissed vankichi’s stale review via a7934a4 July 30, 2020 06:15

vdaas-ci dismissed kevindiu’s stale review via a7934a4 July 30, 2020 06:15

vdaas-ci force-pushed the refactoring/internal/redis branch from cc032ed to a7934a4 Compare July 30, 2020 06:15

fix: apply suggestion

1249f50

Signed-off-by: hlts2 <[email protected]>

kevindiu previously approved these changes Jul 30, 2020

View reviewed changes

vankichi previously approved these changes Jul 30, 2020

View reviewed changes

🤖 Update license headers / Format go codes and yaml files

11417fc

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci dismissed stale reviews from vankichi and kevindiu via 11417fc July 30, 2020 06:39

vdaas-ci approved these changes Jul 30, 2020

View reviewed changes

vankichi merged commit f793475 into master Jul 30, 2020

vankichi deleted the refactoring/internal/redis branch July 30, 2020 07:53

vdaas-ci mentioned this pull request Aug 3, 2020

[patch] Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json #608

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring `internal/db/kvs/redis` package #590

Refactoring `internal/db/kvs/redis` package #590

hlts2 commented Jul 21, 2020 •

edited

Loading

pull-assistant bot commented Jul 21, 2020 •

edited

Loading

vdaas-ci commented Jul 21, 2020

codecov bot commented Jul 21, 2020 •

edited

Loading

kevindiu commented Jul 28, 2020

vdaas-ci commented Jul 28, 2020

github-actions bot Jul 28, 2020

kevindiu commented Jul 28, 2020

kevindiu left a comment

vankichi left a comment

vankichi commented Jul 30, 2020

hlts2 commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

kevindiu left a comment

vankichi left a comment

vankichi commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

vdaas-ci left a comment

Refactoring internal/db/kvs/redis package #590

Refactoring internal/db/kvs/redis package #590

Conversation

hlts2 commented Jul 21, 2020 • edited Loading

Description:

Related Card:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 21, 2020 • edited Loading

vdaas-ci commented Jul 21, 2020

codecov bot commented Jul 21, 2020 • edited Loading

Codecov Report

kevindiu commented Jul 28, 2020

vdaas-ci commented Jul 28, 2020

github-actions bot Jul 28, 2020

Choose a reason for hiding this comment

kevindiu commented Jul 28, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jul 30, 2020

hlts2 commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

vdaas-ci commented Jul 30, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

Refactoring `internal/db/kvs/redis` package #590

Refactoring `internal/db/kvs/redis` package #590

hlts2 commented Jul 21, 2020 •

edited

Loading

pull-assistant bot commented Jul 21, 2020 •

edited

Loading

codecov bot commented Jul 21, 2020 •

edited

Loading