add internal/cache/gache test

[vankichi]

Signed-off-by: vankichi [email protected]

Description:

I added test of internal/cache/gache/gache.go and updated function comment about internal/cache/gache/gache.go.
Also, a bit fix in internal/cache/gache/option_test.go.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (2 commits squashed)

     ✅ add internal/cache/gache test

     ♻️ updatee checkFunc

     ♻️ fix

♻️ fix ... ♻️ fix

Squashed 2 commits:

• ♻️ fix

• ♻️ fix

     ♻️ fix

Powered by Pull Assistant. Last update 1ced5aa ... 132b272. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #583 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   10.96%   11.08%   +0.11%     
==========================================
  Files         403      403              
  Lines       20930    20930              
==========================================
+ Hits         2296     2320      +24     
+ Misses      18365    18341      -24     
  Partials      269      269              

Impacted Files	Coverage Δ
internal/cache/gache/gache.go	100.00% <ø> (+100.00%)	⬆️
internal/errgroup/group.go	93.42% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380c99e...132b272. Read the comment docs.

[kevindiu]

LGTM

[hlts2]

LGTM

[kevindiu]

LGTM

[hlts2]

LGTM

[kevindiu]

LGTM

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache-gache

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.