add cache test #576

kevindiu · 2020-07-13T02:07:36Z

Description:

This PR implements internal/cache test case.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-13T02:07:38Z

Best reviewed: commit by commit

Optimal code review plan

add cache test

Update internal/cache/cache_test.go

fix

Powered by Pull Assistant. Last update f27f280 ... c991bea. Read the comment docs.

vdaas-ci · 2020-07-13T02:10:17Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

kevindiu · 2020-07-13T02:10:34Z

/rebase

vdaas-ci · 2020-07-13T02:19:11Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/cache

codecov · 2020-07-13T02:19:37Z

Codecov Report

Merging #576 into master will increase coverage by 0.10%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   10.86%   10.97%   +0.10%     
==========================================
  Files         403      403              
  Lines       20939    20930       -9     
==========================================
+ Hits         2275     2297      +22     
+ Misses      18396    18364      -32     
- Partials      268      269       +1

Impacted Files	Coverage Δ
internal/cache/option.go	`52.00% <50.00%> (+42.62%)`	⬆️
internal/cache/cache.go	`100.00% <100.00%> (+100.00%)`	⬆️
internal/errgroup/group.go	`93.42% <0.00%> (-1.32%)`	⬇️
internal/file/watch/watch.go	`92.03% <0.00%> (+0.88%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78db9e2...c991bea. Read the comment docs.

github-actions · 2020-07-13T02:26:09Z

internal/cache/cache_test.go

@@ -26,6 +26,13 @@ import (
 	"go.uber.org/goleak"
 )

+var (
+	// Goroutine leak is detected by `fastime`, but it should be ignored in the test because it is an external package.
+	goleakIgnoreOptions = []goleak.Option{


[golangci] _{reported by reviewdog 🐶}
goleakIgnoreOptions is a global variable (gochecknoglobals)

hlts2

LGTM

vankichi · 2020-07-13T08:13:30Z

@kevindiu please confirm description and others required.

internal/cache/cache_test.go

vankichi · 2020-07-13T08:28:02Z

Could you add new case related this?

vankichi · 2020-07-13T08:52:31Z

@kevindiu did you use old template?
I think we should use the latest template. @hlts2 how do you think about it ?

kevindiu · 2020-07-13T08:54:37Z

Could you add new case related this?

I think it is untestable as the default options contains gache type and the WithType() blocks unknown type...

kevindiu · 2020-07-13T08:54:58Z

/rebase

vdaas-ci · 2020-07-13T08:55:43Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/cache

kevindiu · 2020-07-13T08:56:17Z

@kevindiu did you use old template?
I think we should use the latest template. @hlts2 how do you think about it ?

yes I didn't re-generate the test code so i think it is using the old one.

kevindiu · 2020-07-13T09:00:38Z

I will regenerate the test code later

vankichi · 2020-07-15T01:39:15Z

/rebase

vdaas-ci · 2020-07-15T01:39:58Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache

Co-authored-by: Kiichiro YUKAWA <[email protected]>

hlts2

LGTM

internal/cache/option.go

vankichi

LGTM

vankichi · 2020-07-15T06:04:31Z

/rebase
/format
/approve

vdaas-ci · 2020-07-15T06:05:24Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache

vdaas-ci · 2020-07-15T06:06:38Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team size/M type/test Adding tests priority/low labels Jul 13, 2020

vdaas-ci force-pushed the test/internal/cache branch from d73d71c to cab1052 Compare July 13, 2020 02:19

github-actions bot reviewed Jul 13, 2020

View reviewed changes

kevindiu requested a review from hlts2 July 13, 2020 06:09

hlts2 previously approved these changes Jul 13, 2020

View reviewed changes

vankichi reviewed Jul 13, 2020

View reviewed changes

internal/cache/cache_test.go Outdated Show resolved Hide resolved

kevindiu dismissed hlts2’s stale review via 42ac4df July 13, 2020 08:15

kevindiu marked this pull request as ready for review July 13, 2020 08:16

vdaas-ci force-pushed the test/internal/cache branch from 42ac4df to 34f5998 Compare July 13, 2020 08:55

github-actions bot added size/L and removed size/M labels Jul 14, 2020

kevindiu and others added 3 commits July 15, 2020 01:40

add cache test

f27f280

Update internal/cache/cache_test.go

abd7ba1

Co-authored-by: Kiichiro YUKAWA <[email protected]>

fix

c991bea

vdaas-ci force-pushed the test/internal/cache branch from 9c63746 to c991bea Compare July 15, 2020 01:40

kevindiu requested a review from hlts2 July 15, 2020 01:41

hlts2 approved these changes Jul 15, 2020

View reviewed changes

kevindiu commented Jul 15, 2020

View reviewed changes

internal/cache/option.go Show resolved Hide resolved

kevindiu requested a review from vankichi July 15, 2020 05:38

vankichi approved these changes Jul 15, 2020

View reviewed changes

vdaas-ci approved these changes Jul 15, 2020

View reviewed changes

vankichi merged commit 380c99e into master Jul 15, 2020

vankichi deleted the test/internal/cache branch July 15, 2020 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add cache test #576

add cache test #576

kevindiu commented Jul 13, 2020 •

edited

Loading

pull-assistant bot commented Jul 13, 2020 •

edited

Loading

vdaas-ci commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

codecov bot commented Jul 13, 2020 •

edited

Loading

github-actions bot Jul 13, 2020

hlts2 left a comment

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

kevindiu commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

kevindiu commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vankichi commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

hlts2 left a comment

vankichi left a comment

vankichi commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

vdaas-ci left a comment

add cache test #576

add cache test #576

Conversation

kevindiu commented Jul 13, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 13, 2020 • edited Loading

vdaas-ci commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

codecov bot commented Jul 13, 2020 • edited Loading

Codecov Report

github-actions bot Jul 13, 2020

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

kevindiu commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

kevindiu commented Jul 13, 2020

kevindiu commented Jul 13, 2020

vankichi commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

hlts2 left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

vdaas-ci commented Jul 15, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Jul 13, 2020 •

edited

Loading

pull-assistant bot commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading