[agent-NGT] refactor pkg/agent/core/service using FOP #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rintaro Okamura <[email protected]>
|
Best reviewed: commit by commit
Optimal code review plan
|
|
[CHATOPS:HELP] ChatOps commands.
|
kpango
reviewed
Jul 9, 2020
Signed-off-by: Rintaro Okamura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## refactor/agent-ngt-sidecar/improve-s3-backup-behavior #566 +/- ##
=========================================================================================
+ Coverage 10.16% 10.44% +0.28%
=========================================================================================
Files 405 403 -2
Lines 21007 20437 -570
=========================================================================================
Hits 2135 2135
+ Misses 18612 18042 -570
Partials 260 260
Continue to review full report at Codecov.
|
Signed-off-by: Rintaro Okamura <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| type args struct { | ||
| opts []core.Option | ||
| } | ||
| type fields struct { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
struct of size 224 bytes could be of size 216 bytes (maligned)
| type args struct { | ||
| ctx context.Context | ||
| } | ||
| type fields struct { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
struct of size 224 bytes could be of size 216 bytes (maligned)
| */ | ||
| } | ||
|
|
||
| for _, test := range tests { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
copylocks: range var test copies lock: github.com/vdaas/vald/pkg/agent/core/ngt/service.test contains github.com/vdaas/vald/pkg/agent/core/ngt/service.fields contains sync.Mutex (govet)
| ivc: test.fields.ivc, | ||
| dvc: test.fields.dvc, | ||
| indexing: test.fields.indexing, | ||
| saveMu: test.fields.saveMu, |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
copylocks: literal copies lock value from test.fields.saveMu: sync.Mutex (govet)
| */ | ||
| } | ||
|
|
||
| for _, test := range tests { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
copylocks: range var test copies lock: github.com/vdaas/vald/pkg/agent/core/ngt/service.test contains github.com/vdaas/vald/pkg/agent/core/ngt/service.fields contains sync.Mutex (govet)
| ivc: test.fields.ivc, | ||
| dvc: test.fields.dvc, | ||
| indexing: test.fields.indexing, | ||
| saveMu: test.fields.saveMu, |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
copylocks: literal copies lock value from test.fields.saveMu: sync.Mutex (govet)
rinx
added a commit
that referenced
this pull request
Jul 13, 2020
* 🔧 inject ngt service config from usecase layer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use filepath.Clean Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests Signed-off-by: Rintaro Okamura <[email protected]>
vdaas-ci
pushed a commit
that referenced
this pull request
Jul 15, 2020
* 🔧 inject ngt service config from usecase layer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use filepath.Clean Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests Signed-off-by: Rintaro Okamura <[email protected]>
vdaas-ci
pushed a commit
that referenced
this pull request
Jul 20, 2020
* 🔧 inject ngt service config from usecase layer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use filepath.Clean Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests Signed-off-by: Rintaro Okamura <[email protected]>
vdaas-ci
pushed a commit
that referenced
this pull request
Jul 20, 2020
* 🔧 inject ngt service config from usecase layer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use filepath.Clean Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests Signed-off-by: Rintaro Okamura <[email protected]>
kpango
pushed a commit
that referenced
this pull request
Jul 22, 2020
* ♻️ not to overwrite existing backup files Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests for internal/compress Signed-off-by: Rintaro Okamura <[email protected]> * 🔧 add default_pool_size option / add internal/json package Signed-off-by: Rintaro Okamura <[email protected]> ♻️ fix import Signed-off-by: Rintaro Okamura <[email protected]> * ✨ Add metadata package to write agent metadata when the index saved. Signed-off-by: Rintaro Okamura <[email protected]> * ✨ revise file.Open interface Signed-off-by: Rintaro Okamura <[email protected]> * ✅ fix file test Signed-off-by: Rintaro Okamura <[email protected]> * ✅ fix json tests Signed-off-by: Rintaro Okamura <[email protected]> * 🎨 use filepath.Join Signed-off-by: Rintaro Okamura <[email protected]> * ✨ revise watching method for ngt index backup files Signed-off-by: Rintaro Okamura <[email protected]> * ✅ remove dps from ngt_test Signed-off-by: Rintaro Okamura <[email protected]> * ✨ kill own process when NGT index cannot be loaded within timeout Signed-off-by: Rintaro Okamura <[email protected]> * 🚨 fix deepsource issues Signed-off-by: Rintaro Okamura <[email protected]> * 🚚 move internal/json -> internal/encoding/json Signed-off-by: Rintaro Okamura <[email protected]> * [agent-NGT] refactor pkg/agent/core/service using FOP (#566) * 🔧 inject ngt service config from usecase layer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use filepath.Clean Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update tests Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ refactor initNGT func Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update Signed-off-by: Rintaro Okamura <[email protected]> * ✨ add isValid flag to metadata Signed-off-by: Rintaro Okamura <[email protected]> * 💚 revise fetch depth for run test workflow Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use isInvalid because it should be default to false Signed-off-by: Rintaro Okamura <[email protected]> * 🎨 fix tag format Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ fix poststop logic Signed-off-by: Rintaro Okamura <[email protected]> * ✨ add Escape() method to errgroup Signed-off-by: Rintaro Okamura <[email protected]> * 📦 add *.containers field Signed-off-by: Rintaro Okamura <[email protected]> * Revert "📦 add *.containers field" This reverts commit f82d52e. * ✅ update Signed-off-by: Rintaro Okamura <[email protected]> * Revert "✅ update" This reverts commit 1c6bce6. * Revert ":sparkles: add Escape() method to errgroup" This reverts commit 6a4dad6. * ♻️ exit safely using goroutine Signed-off-by: Rintaro Okamura <[email protected]> * 🚚 move internal/metadata -> pkg/agent/internal/metadata Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ add defaultPoolSize const Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ pass cfg struct to agent service Signed-off-by: Rintaro Okamura <[email protected]> * 🐳 fix dockerfiles Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ add watch_enabled & auto_backup_enabled options Signed-off-by: Rintaro Okamura <[email protected]> * ✅ fix tests Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ revise agent-ngt codes based on suggestions Signed-off-by: Rintaro Okamura <[email protected]> * ✅ update Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ revise observer poststop Signed-off-by: Rintaro Okamura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
further refactoring will be done with branch #556.
Related Issue:
nothing.
How Has This Been Tested?:
nothing
Environment:
Types of changes:
Changes to Core Features:
Checklist: