fix failed test

[vankichi]

Signed-off-by: vankichi [email protected]

Description:

I fixed below tests which are failed.

• internal/log/glg/glg_test
• internal/servers/server/option_tset

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.3
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.11.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     ✅ 🐛 fix failed test

     ⬆️ update

     Revert ":arrow_up: update"

Powered by Pull Assistant. Last update c033293 ... a96132e. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #561 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   10.17%   10.17%   -0.01%     
==========================================
  Files         403      403              
  Lines       20874    20874              
==========================================
- Hits         2124     2123       -1     
- Misses      18490    18491       +1     
  Partials      260      260              

Impacted Files	Coverage Δ
internal/errgroup/group.go	93.42% <0.00%> (-1.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a697749...a96132e. Read the comment docs.

[kevindiu]

seems the CI still failed.

[vankichi]

It is because of panic pattern test 😓
I think we have to make decision about it.

[vankichi]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/fix-failed-internal-test

[kevindiu]

this error occurs...

# github.com/vdaas/vald/internal/io [github.com/vdaas/vald/internal/io.test]
io/io_test.go:429:28: not enough arguments in call to test.checkFunc
	have (want, io.Writer, error)
	want (want, io.Writer, string, error)

[kevindiu]

Also after I ran the go test command in internal folder, the go.sum file changed. Should we fix it also?

git diff ../go.sum
diff --git a/go.sum b/go.sum
index 47181348..6955a0c1 100644
--- a/go.sum
+++ b/go.sum
@@ -832,6 +832,7 @@ golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2/go.mod h1:tRJNPiyCQ0inRvYxb
 golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 h1:SvFZT6jyqRaOeXpc5h/JSfZenJ2O330aBsf7JfSUXmQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
+golang.org/x/time v0.0.0-20191024005414-555d28b269f0 h1:/5xXl8Y5W96D+TtHSlonuFqGHIWVuyCkGJLwGh9JJFs=
 golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/tools v0.0.0-20180525024113-a5b4c53f6e8b/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=

[vankichi]

io/io_test.go:429:28: not enough arguments in call to test.checkFunc

I could not confirm this problem... 😕
and, CI is success.

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

[kevindiu]

LGTM

[hlts2]

LGTM

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/fix-failed-internal-test

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.