Added test case for `internal/file/watch/option_test.go` #518

hlts2 · 2020-06-25T08:46:39Z

Signed-off-by: hlts2 [email protected]

Description:

I added test case for internal/file/watch/option_test.go.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-06-25T08:46:41Z

Best reviewed: commit by commit

Optimal code review plan

feat: options test

Powered by Pull Assistant. Last update 20e2f9d ... 20e2f9d. Read the comment docs.

internal/file/watch/option_test.go

hlts2 · 2020-06-29T01:34:24Z

/rebase

vdaas-ci · 2020-06-29T01:34:58Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/file_watch_option

codecov · 2020-06-29T01:43:25Z

Codecov Report

Merging #518 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #518      +/-   ##
=========================================
- Coverage    9.28%   9.26%   -0.02%     
=========================================
  Files         402     402              
  Lines       20859   20831      -28     
=========================================
- Hits         1936    1931       -5     
+ Misses      18670   18647      -23     
  Partials      253     253

Impacted Files	Coverage Δ
internal/config/log.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/config/tls.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/log/mock/logger.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/config/config.go	`0.00% <0.00%> (-15.79%)`	⬇️
internal/runner/runner.go	`90.38% <0.00%> (-0.92%)`	⬇️
internal/tls/tls.go	`0.00% <0.00%> (ø)`
pkg/meta/redis/usecase/meta.go	`0.00% <0.00%> (ø)`
pkg/agent/core/ngt/service/ngt.go	`0.00% <0.00%> (ø)`
internal/net/grpc/status/status.go	`0.00% <0.00%> (ø)`
pkg/meta/cassandra/usecase/meta.go	`0.00% <0.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76ef1b...20e2f9d. Read the comment docs.

kevindiu · 2020-06-29T05:30:06Z

/rebase

vdaas-ci · 2020-06-29T05:30:41Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/file_watch_option

kevindiu

LGTM

vankichi · 2020-06-30T02:52:20Z

/rebase

vdaas-ci · 2020-06-30T02:53:04Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

vankichi

LGTM

vankichi · 2020-06-30T03:32:00Z

/rebase
/format
/approve

vdaas-ci · 2020-06-30T03:32:34Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

vdaas-ci · 2020-06-30T03:33:20Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi · 2020-07-06T01:24:04Z

/rebase
/format
/approve

vdaas-ci · 2020-07-06T01:24:38Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

Signed-off-by: hlts2 <[email protected]>

vdaas-ci · 2020-07-06T01:25:32Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team size/XXL type/test Adding tests priority/low labels Jun 25, 2020

github-actions bot reviewed Jun 25, 2020

View reviewed changes

internal/file/watch/option_test.go Show resolved Hide resolved

internal/file/watch/option_test.go Show resolved Hide resolved

vdaas-ci force-pushed the test/internal/file_watch_option branch from 4139a9c to 891e9ee Compare June 29, 2020 01:35

vdaas-ci force-pushed the test/internal/file_watch_option branch from 891e9ee to 69c04ed Compare June 29, 2020 05:30

kevindiu previously approved these changes Jun 29, 2020

View reviewed changes

vdaas-ci dismissed kevindiu’s stale review via c54acd5 June 30, 2020 02:53

vdaas-ci force-pushed the test/internal/file_watch_option branch from 69c04ed to c54acd5 Compare June 30, 2020 02:53

vankichi previously approved these changes Jun 30, 2020

View reviewed changes

vdaas-ci previously approved these changes Jun 30, 2020

View reviewed changes

feat: options test

20e2f9d

Signed-off-by: hlts2 <[email protected]>

vdaas-ci dismissed stale reviews from vankichi and themself via 20e2f9d July 6, 2020 01:24

vdaas-ci force-pushed the test/internal/file_watch_option branch from c54acd5 to 20e2f9d Compare July 6, 2020 01:24

vdaas-ci approved these changes Jul 6, 2020

View reviewed changes

vankichi merged commit 94f6f1f into master Jul 6, 2020

vankichi deleted the test/internal/file_watch_option branch July 6, 2020 01:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test case for `internal/file/watch/option_test.go` #518

Added test case for `internal/file/watch/option_test.go` #518

hlts2 commented Jun 25, 2020 •

edited

Loading

pull-assistant bot commented Jun 25, 2020 •

edited

Loading

hlts2 commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

codecov bot commented Jun 29, 2020 •

edited

Loading

kevindiu commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

kevindiu left a comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vankichi left a comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci left a comment

vankichi commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

vdaas-ci left a comment

Added test case for internal/file/watch/option_test.go #518

Added test case for internal/file/watch/option_test.go #518

Conversation

hlts2 commented Jun 25, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jun 25, 2020 • edited Loading

hlts2 commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

codecov bot commented Jun 29, 2020 • edited Loading

Codecov Report

kevindiu commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

Added test case for `internal/file/watch/option_test.go` #518

Added test case for `internal/file/watch/option_test.go` #518

hlts2 commented Jun 25, 2020 •

edited

Loading

pull-assistant bot commented Jun 25, 2020 •

edited

Loading

codecov bot commented Jun 29, 2020 •

edited

Loading