Feature/drawio

[taisuou]

Description:

added assets for documentation of vald

1.separated overflow image into blocks and parts.

2.added scratchpad. you can copy and paste blocks and parts.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.3
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.11.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (2 commits squashed)

     Added Vald Architecture Dataflow.drawio

     Update Vald Architecture Dataflow.drawio

     Update Vald Architecture Dataflow.drawio

     Update Vald Architecture Dataflow.drawio

     Added Vald Architecture Assets.drawio

     Update Vald Architecture Assets.drawio

     Update Vald Architecture Assets.drawio

     Update Vald Architecture Assets.drawio

Update Vald Architec... ... Update Vald Architec...

Squashed 2 commits:

• Update Vald Architecture Assets.drawio

• Update Vald Architecture Assets.drawio

     Merge branch 'master' into feature/drawio

Powered by Pull Assistant. Last update 064c567 ... 5ff5cbb. Read the comment docs.

[kpango]

LGTM

[kpango]

/rebase
/approve

[vdaas-ci]

[REBASE] Rebase triggered by kpango for branch: feature/drawio

[vdaas-ci]

[REBASE] Failed to rebase.

[vankichi]

@taisuou
Could you please use underscore _ instead of space for naming file?

[kpango]

@vankichi I think is not necessary. We already use space naming delimiter, like https://github.com/vdaas/vald/blob/master/design/Vald%20Architecture%20Overview.drawio

[kpango]

is it important your use-case?

[vankichi]

If these files seem just template file, I don't mind too.
But, if we set these files as link at any pages in WebSite, it will not work well in WebSite.
The situation that we will set won't occur, I agree with you.

[kpango]

this file never read from the website because we should export them into SVG or PNG or webP.
we should care about naming then.

[vankichi]

Oh, I misundestand.
OK! NP!

[taisuou]

Sorry for late reaction....