Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add trace spans and metrics for agent-ngt and index-manager #389

Merged
merged 7 commits into from
May 21, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 20, 2020

Description:

  • add trace spans for several functions that called by daemons
  • add metrics about create index execution (agent)
  • add initial_delay_max_duration that affects to start auto-index daemon after random duration within it.

Related Issue:

#343

How Has This Been Tested?:

nothing.

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 20, 2020

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #389 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #389      +/-   ##
=========================================
- Coverage    7.91%   7.88%   -0.03%     
=========================================
  Files         356     356              
  Lines       18319   18380      +61     
=========================================
  Hits         1450    1450              
- Misses      16660   16721      +61     
  Partials      209     209              
Impacted Files Coverage Δ
internal/config/ngt.go 0.00% <0.00%> (ø)
internal/observability/metrics/agent/ngt/ngt.go 0.00% <0.00%> (ø)
pkg/agent/ngt/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/agent/ngt/service/ngt.go 0.00% <0.00%> (ø)
pkg/manager/index/service/indexer.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8dc984...c00ae07. Read the comment docs.

@github-actions github-actions bot added size/M and removed size/M labels May 20, 2020
@rinx rinx force-pushed the feature/agent-indexer/add-trace-spans-and-metrics branch from 73da3c2 to 50c3683 Compare May 20, 2020 01:56
@github-actions github-actions bot added size/M team/set SET team and removed size/M labels May 20, 2020
@rinx rinx force-pushed the feature/agent-indexer/add-trace-spans-and-metrics branch from d0af9e0 to 48fefcf Compare May 20, 2020 05:27
@rinx
Copy link
Contributor Author

rinx commented May 20, 2020

/rebase

rinx added 4 commits May 20, 2020 15:44
Signed-off-by: Rintaro Okamura <[email protected]>

:bug: Fix

Signed-off-by: Rintaro Okamura <[email protected]>

:bug: Fix

Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
@rinx rinx force-pushed the feature/agent-indexer/add-trace-spans-and-metrics branch from 48fefcf to 2237262 Compare May 20, 2020 06:44
@rinx rinx marked this pull request as ready for review May 20, 2020 06:44
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@rinx rinx requested review from kpango and hlts2 May 21, 2020 01:49
Co-authored-by: Rintaro Okamura <[email protected]>
@kpango
Copy link
Collaborator

kpango commented May 21, 2020

/format
/approve

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango merged commit 302d624 into master May 21, 2020
@kpango kpango deleted the feature/agent-indexer/add-trace-spans-and-metrics branch May 21, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants