Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add gen-test command for chatops #379

Merged
merged 4 commits into from
May 19, 2020
Merged

✨ Add gen-test command for chatops #379

merged 4 commits into from
May 19, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 14, 2020 •
edited
Loading

Signed-off-by: Rintaro Okamura [email protected]

Description:

  • added ChatOps /gen-test command to run gotests.
  • revise Makefile gotests/gen task
  • improve make startup time

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 14, 2020 •
edited
Loading

Score: 0.97

Best reviewed: commit by commit

Optimal code review plan

     ✨ Add gen-test command for chatops

     ⚡ improve make startup time

     ♻️ Add dependency of GO_TEST_SOURCES

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update 083f62d ... 94bae13. Read the comment docs.

@rinx rinx requested review from a team, hlts2 and kevindiu and removed request for a team May 14, 2020 05:25
@rinx rinx requested review from kpango and vankichi May 14, 2020 05:26
@kpango
Copy link
Collaborator

kpango commented May 18, 2020

Could you please resolve conflicts?

@rinx rinx force-pushed the ci/chatops/add-gen-test-command branch from 3f1cc69 to e83fcda Compare May 19, 2020 08:17
@github-actions github-actions bot added size/L and removed size/S labels May 19, 2020
@rinx rinx force-pushed the ci/chatops/add-gen-test-command branch from e83fcda to 8813d19 Compare May 19, 2020 08:19
@rinx
Copy link
Contributor Author

rinx commented May 19, 2020

@kpango resolved it 😉

@vankichi @kevindiu @hlts2 I revised gotests Makefile tasks. please review it and ask me anything.
it can be run parallel by using -j option of make

make -j 4 gotests/gen

kpango
kpango previously approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented May 19, 2020 •
edited
Loading

I just tried to it.It seems running correctly.
Awsome! you may be makefile-master

@vankichi vankichi closed this May 19, 2020
@vankichi vankichi reopened this May 19, 2020
vankichi
vankichi previously approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: ci/chatops/add-gen-test-command

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kpango via 7241974 May 19, 2020 09:18
@rinx
Copy link
Contributor Author

rinx commented May 19, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: ci/chatops/add-gen-test-command

@vdaas-ci vdaas-ci force-pushed the ci/chatops/add-gen-test-command branch from 7241974 to 94bae13 Compare May 19, 2020 09:28
hlts2
hlts2 approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit f8dc984 into master May 19, 2020
@kpango kpango deleted the ci/chatops/add-gen-test-command branch May 19, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi left review comments

@kpango kpango kpango left review comments

@kevindiu kevindiu Awaiting requested review from kevindiu

Assignees
No one assigned
Labels
area/makefile priority/low size/L team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rinx @kpango @vankichi @vdaas-ci @hlts2