-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests of internal/log
and modified to match the test template
#368
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
/rebase |
[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test |
internal/log
: Fix failing tests and modified to match the test template internal/log
and modified to match the test template
LGTM |
/rebase |
[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test |
68c6d6a
to
d080355
Compare
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
======================================
Coverage 7.90% 7.90%
======================================
Files 346 346
Lines 17804 17804
======================================
Hits 1408 1408
Misses 16215 16215
Partials 181 181 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/rebase
/format
/approve
/rebase |
[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test |
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
d080355
to
2a48daf
Compare
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/format
Signed-off-by: hlts2 [email protected]
Description:
I fixed faling tests of
internal/log
package.And I modified to match the test template.
The following packages are directly under
internal / log
.I am planning to fix these packages in another PR without including them in this PR.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: