Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests of internal/log and modified to match the test template #368

Merged
merged 3 commits into from
May 13, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented May 11, 2020

Signed-off-by: hlts2 [email protected]

Description:

I fixed faling tests of internal/log package.
And I modified to match the test template.

The following packages are directly under internal / log.
I am planning to fix these packages in another PR without including them in this PR.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 11, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: failing tests and modified to match template

     fix: add comment

     fix: typo

Powered by Pull Assistant. Last update 807cd4a ... 2add1af. Read the comment docs.

@hlts2
Copy link
Collaborator Author

hlts2 commented May 11, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test

@hlts2 hlts2 requested review from kmrmt and kevindiu May 11, 2020 06:59
@hlts2 hlts2 changed the title internal/log: Fix failing tests and modified to match the test template Fix failing tests of internal/log and modified to match the test template May 11, 2020
@kevindiu
Copy link
Contributor

LGTM

@hlts2
Copy link
Collaborator Author

hlts2 commented May 12, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test

@vdaas-ci vdaas-ci force-pushed the test/internal/log_test branch from 68c6d6a to d080355 Compare May 12, 2020 02:10
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #368   +/-   ##
======================================
  Coverage    7.90%   7.90%           
======================================
  Files         346     346           
  Lines       17804   17804           
======================================
  Hits         1408    1408           
  Misses      16215   16215           
  Partials      181     181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74cb61...2add1af. Read the comment docs.

internal/log/log_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rebase
/format
/approve

@hlts2
Copy link
Collaborator Author

hlts2 commented May 13, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_test

@vdaas-ci vdaas-ci force-pushed the test/internal/log_test branch from d080355 to 2a48daf Compare May 13, 2020 01:36
Signed-off-by: hlts2 <[email protected]>
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/format

@kpango kpango merged commit fcabeaa into master May 13, 2020
@kpango kpango deleted the test/internal/log_test branch May 13, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants