Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Revise CI: coverage settings #347

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 24, 2020

Signed-off-by: Rintaro Okamura [email protected]

Description:

Revised calculation settings of coverages.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <[email protected]>
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     💚 Revise coverage CI settings

Powered by Pull Assistant. Last update 7d00d67 ... 7d00d67. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   70.79%   70.79%           
=======================================
  Files          41       41           
  Lines        1839     1839           
=======================================
  Hits         1302     1302           
  Misses        472      472           
  Partials       65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46d63f...7d00d67. Read the comment docs.

@rinx rinx marked this pull request as ready for review April 24, 2020 02:10
@kpango
Copy link
Collaborator

kpango commented Apr 24, 2020

LGTM
/approve

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit efd86b1 into master Apr 24, 2020
@kpango kpango deleted the ci/codecov/revise-settings branch April 24, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants