-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #2733 to release/v1.7 for [BUGFIX] resolve agent GetGraphStatistics API double-free error problem #2738
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ | |
.github/workflows/dockers-ci-container-image.yaml | ||
.github/workflows/dockers-dev-container-image.yaml | ||
.github/workflows/dockers-discoverer-k8s-image.yaml | ||
.github/workflows/dockers-example-client-image.yaml | ||
.github/workflows/dockers-gateway-filter-image.yaml | ||
.github/workflows/dockers-gateway-lb-image.yaml | ||
.github/workflows/dockers-gateway-mirror-image.yaml | ||
|
@@ -97,6 +98,7 @@ | |
.github/workflows/dockers-index-correction-image.yaml | ||
.github/workflows/dockers-index-creation-image.yaml | ||
.github/workflows/dockers-index-deletion-image.yaml | ||
.github/workflows/dockers-index-deletion.yaml | ||
.github/workflows/dockers-index-operator-image.yaml | ||
.github/workflows/dockers-index-save-image.yaml | ||
.github/workflows/dockers-loadtest-image.yaml | ||
|
@@ -123,7 +125,7 @@ | |
.github/workflows/semver-patch.yaml | ||
.github/workflows/test-hack.yaml | ||
.github/workflows/unit-test.yaml | ||
.github/workflows/update-actions.yaml | ||
.github/workflows/update-deps.yaml | ||
.github/workflows/update-protobuf.yaml | ||
.github/workflows/update-pull-request-and-issue-template.yaml | ||
.github/workflows/update-web-docs.yaml | ||
|
@@ -199,8 +201,6 @@ apis/grpc/v1/vald/update_vtproto.pb.go | |
apis/grpc/v1/vald/upsert.pb.go | ||
apis/grpc/v1/vald/upsert_vtproto.pb.go | ||
apis/grpc/v1/vald/vald.go | ||
apis/proto/buf.lock | ||
apis/proto/buf.yaml | ||
apis/proto/v1/agent/core/agent.proto | ||
apis/proto/v1/agent/sidecar/sidecar.proto | ||
apis/proto/v1/discoverer/discoverer.proto | ||
|
@@ -304,7 +304,8 @@ assets/test/templates/option/function.tmpl | |
assets/test/templates/option/header.tmpl | ||
assets/test/templates/option/results.tmpl | ||
buf.gen.yaml | ||
buf.work.yaml | ||
buf.lock | ||
buf.yaml | ||
charts/vald-benchmark-operator/Chart.yaml | ||
charts/vald-benchmark-operator/README.md | ||
charts/vald-benchmark-operator/README.md.gotmpl | ||
|
@@ -490,6 +491,8 @@ cmd/index/job/correction/sample.yaml | |
cmd/index/job/creation/main.go | ||
cmd/index/job/creation/main_test.go | ||
cmd/index/job/creation/sample.yaml | ||
cmd/index/job/deletion/main.go | ||
cmd/index/job/deletion/sample.yaml | ||
Comment on lines
+494
to
+495
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add Unit Tests for New Deletion Job New files Would you like assistance in generating unit tests for the deletion job? |
||
cmd/index/job/readreplica/rotate/main.go | ||
cmd/index/job/readreplica/rotate/main_test.go | ||
cmd/index/job/readreplica/rotate/sample.yaml | ||
|
@@ -537,13 +540,15 @@ dockers/dev/Dockerfile | |
dockers/dev/README.md | ||
dockers/discoverer/k8s/Dockerfile | ||
dockers/discoverer/k8s/README.md | ||
dockers/example/client/Dockerfile | ||
dockers/gateway/filter/Dockerfile | ||
dockers/gateway/filter/README.md | ||
dockers/gateway/lb/Dockerfile | ||
dockers/gateway/lb/README.md | ||
dockers/gateway/mirror/Dockerfile | ||
dockers/index/job/correction/Dockerfile | ||
dockers/index/job/creation/Dockerfile | ||
dockers/index/job/deletion/Dockerfile | ||
dockers/index/job/readreplica/rotate/Dockerfile | ||
dockers/index/job/save/Dockerfile | ||
dockers/index/operator/Dockerfile | ||
|
@@ -838,6 +843,7 @@ internal/config/grpc_test.go | |
internal/config/index.go | ||
internal/config/index_creation.go | ||
internal/config/index_creation_test.go | ||
internal/config/index_deleter.go | ||
internal/config/index_operator.go | ||
internal/config/index_operator_test.go | ||
internal/config/index_save.go | ||
|
@@ -1455,6 +1461,8 @@ k8s/index/job/correction/configmap.yaml | |
k8s/index/job/correction/cronjob.yaml | ||
k8s/index/job/creation/configmap.yaml | ||
k8s/index/job/creation/cronjob.yaml | ||
k8s/index/job/deletion/configmap.yaml | ||
k8s/index/job/deletion/cronjob.yaml | ||
k8s/index/job/save/configmap.yaml | ||
k8s/index/job/save/cronjob.yaml | ||
k8s/index/operator/configmap.yaml | ||
|
@@ -1789,6 +1797,10 @@ pkg/index/job/creation/service/options.go | |
pkg/index/job/creation/service/options_test.go | ||
pkg/index/job/creation/usecase/creation.go | ||
pkg/index/job/creation/usecase/creation_test.go | ||
pkg/index/job/deletion/config/config.go | ||
pkg/index/job/deletion/service/deleter.go | ||
pkg/index/job/deletion/service/options.go | ||
pkg/index/job/deletion/usecase/deletion.go | ||
Comment on lines
+1800
to
+1803
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Implement Comprehensive Documentation and Testing The addition of several files under
|
||
pkg/index/job/readreplica/rotate/config/config.go | ||
pkg/index/job/readreplica/rotate/config/config_test.go | ||
pkg/index/job/readreplica/rotate/service/options.go | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,4 +93,4 @@ LABEL maintainer="vdaas.org vald team <[email protected]>" | |
COPY --from=builder /usr/bin/agent /usr/bin/agent | ||
# skipcq: DOK-DL3002 | ||
USER nonroot:nonroot | ||
ENTRYPOINT ["/usr/bin/agent"] | ||
ENTRYPOINT ["/usr/bin/agent"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,4 +84,4 @@ LABEL maintainer="vdaas.org vald team <[email protected]>" | |
COPY --from=builder /usr/bin/sidecar /usr/bin/sidecar | ||
# skipcq: DOK-DL3002 | ||
USER nonroot:nonroot | ||
ENTRYPOINT ["/usr/bin/sidecar"] | ||
ENTRYPOINT ["/usr/bin/sidecar"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,4 +92,4 @@ LABEL maintainer="vdaas.org vald team <[email protected]>" | |
COPY --from=builder /usr/bin/client /usr/bin/client | ||
# skipcq: DOK-DL3002 | ||
USER nonroot:nonroot | ||
ENTRYPOINT ["/usr/bin/client"] | ||
ENTRYPOINT ["/usr/bin/client"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,7 @@ RUN --mount=type=bind,target=.,rw \ | |
FROM gcr.io/distroless/static:nonroot | ||
LABEL maintainer="vdaas.org vald team <[email protected]>" | ||
COPY --from=builder /usr/bin/index-deletion /usr/bin/index-deletion | ||
COPY cmd/index/job/deletion/sample.yaml /etc/server/config.yaml | ||
# skipcq: DOK-DL3002 | ||
USER nonroot:nonroot | ||
ENTRYPOINT ["/usr/bin/index-deletion"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,14 @@ replace ( | |
github.com/goccy/go-json => github.com/goccy/go-json v0.10.3 | ||
github.com/golang/protobuf => github.com/golang/protobuf v1.5.4 | ||
github.com/kpango/glg => github.com/kpango/glg v1.6.15 | ||
github.com/pkg/sftp => github.com/pkg/sftp v1.13.6 | ||
golang.org/x/crypto => golang.org/x/crypto v0.28.0 | ||
golang.org/x/net => golang.org/x/net v0.30.0 | ||
golang.org/x/text => golang.org/x/text v0.19.0 | ||
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20241007155032-5fefd90f89a9 | ||
google.golang.org/genproto/googleapis/api => google.golang.org/genproto/googleapis/api v0.0.0-20241007155032-5fefd90f89a9 | ||
google.golang.org/genproto/googleapis/rpc => google.golang.org/genproto/googleapis/rpc v0.0.0-20241007155032-5fefd90f89a9 | ||
google.golang.org/grpc => google.golang.org/grpc v1.67.1 | ||
github.com/pkg/sftp => github.com/pkg/sftp v1.13.7 | ||
golang.org/x/crypto => golang.org/x/crypto v0.29.0 | ||
golang.org/x/net => golang.org/x/net v0.31.0 | ||
golang.org/x/text => golang.org/x/text v0.20.0 | ||
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20241104194629-dd2ea8efbc28 | ||
google.golang.org/genproto/googleapis/api => google.golang.org/genproto/googleapis/api v0.0.0-20241104194629-dd2ea8efbc28 | ||
google.golang.org/genproto/googleapis/rpc => google.golang.org/genproto/googleapis/rpc v0.0.0-20241104194629-dd2ea8efbc28 | ||
google.golang.org/grpc => google.golang.org/grpc v1.68.0 | ||
google.golang.org/protobuf => google.golang.org/protobuf v1.35.1 | ||
gopkg.in/yaml.v2 => gopkg.in/yaml.v2 v2.4.0 | ||
gopkg.in/yaml.v3 => gopkg.in/yaml.v3 v3.0.1 | ||
|
@@ -23,20 +23,20 @@ replace ( | |
require ( | ||
github.com/kpango/fuid v0.0.0-20221203053508-503b5ad89aa1 | ||
github.com/kpango/glg v1.6.14 | ||
github.com/vdaas/vald-client-go v1.7.13 | ||
github.com/vdaas/vald-client-go v1.7.14 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Version mismatch with PR objectives The PR objectives state this is a backport to v1.7.13, but this file requires Please align the version with the backport target (v1.7.13) or provide justification for using a newer version. |
||
gonum.org/v1/hdf5 v0.0.0-20210714002203-8c5d23bc6946 | ||
google.golang.org/grpc v1.67.1 | ||
) | ||
|
||
require ( | ||
buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240717164558-a6c49f84cc0f.2 // indirect | ||
buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.35.1-20240920164238-5a7b106cbb87.1 // indirect | ||
github.com/goccy/go-json v0.10.2 // indirect | ||
github.com/kpango/fastime v1.1.9 // indirect | ||
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect | ||
golang.org/x/net v0.28.0 // indirect | ||
golang.org/x/sys v0.26.0 // indirect | ||
golang.org/x/text v0.19.0 // indirect | ||
google.golang.org/genproto/googleapis/api v0.0.0-20240814211410-ddb44dafa142 // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20240930140551-af27646dc61f // indirect | ||
golang.org/x/net v0.29.0 // indirect | ||
golang.org/x/sys v0.27.0 // indirect | ||
golang.org/x/text v0.20.0 // indirect | ||
google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20241021214115-324edc3d5d38 // indirect | ||
google.golang.org/protobuf v1.35.1 // indirect | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Update References After Renaming Workflow File
The workflow file has been renamed to
.github/workflows/update-deps.yaml
. Please check and update any references to the old filename to prevent broken links or misconfigurations.