Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete target agent pod at index correction #2735

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix delete target agent pod at index correction #2735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5977085
fix index correction e2e test
kmrmt Nov 7, 2024
b44e0e3
style: format code with Gofumpt and Prettier
deepsource-autofix[bot] Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions tests/e2e/crud/crud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"fmt"
"os"
"os/exec"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -802,8 +803,19 @@ func TestE2EIndexJobCorrection(t *testing.T) {
}

t.Log("Test case 2: execute index correction after one agent removed")
t.Log("removing vald-agent-0...")
cmd := exec.CommandContext(ctx, "sh", "-c", "kubectl delete pod vald-agent-0 && kubectl wait --for=condition=Ready pod/vald-agent-0")
detail, err := op.IndexDetail(t, ctx)
if err != nil {
t.Fatalf("an error occurred: %s", err)
}
var target string
for a, c := range detail.Counts {
if c.Stored > 0 {
target = strings.Split(a, ":")[0]
break
}
}

cmd := exec.CommandContext(ctx, "sh", "-c", fmt.Sprintf("kubectl get pods -o custom-columns=:metadata.name --no-headers=true --field-selector=\"status.podIP=%s\"", target))
out, err := cmd.Output()
if err != nil {
if exitErr, ok := err.(*exec.ExitError); ok {
Expand All @@ -812,6 +824,18 @@ func TestE2EIndexJobCorrection(t *testing.T) {
t.Fatalf("unexpected error on creating job: %v", err)
}
}
agent := strings.TrimRight(string(out), "\n")

t.Logf("removing %s...", agent)
cmd = exec.CommandContext(ctx, "sh", "-c", fmt.Sprintf("kubectl delete pod %s && kubectl wait --for=condition=Ready pod/%s", agent, agent))
out, err = cmd.Output()
if err != nil {
if exitErr, ok := err.(*exec.ExitError); ok {
t.Fatalf("%s, %s, %v", string(out), string(exitErr.Stderr), err)
} else {
t.Fatalf("unexpected error on creating job: %v", err)
}
}
t.Log(string(out))

// correct the deleted index
Expand Down
10 changes: 10 additions & 0 deletions tests/e2e/operation/operation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ type Client interface {
CreateIndex(t *testing.T, ctx context.Context) error
SaveIndex(t *testing.T, ctx context.Context) error
IndexInfo(t *testing.T, ctx context.Context) (*payload.Info_Index_Count, error)
IndexDetail(t *testing.T, ctx context.Context) (*payload.Info_Index_Detail, error)
}

type client struct {
Expand Down Expand Up @@ -182,6 +183,15 @@ func (c *client) IndexInfo(t *testing.T, ctx context.Context) (*payload.Info_Ind
return client.IndexInfo(ctx, &payload.Empty{})
}

func (c *client) IndexDetail(t *testing.T, ctx context.Context) (*payload.Info_Index_Detail, error) {
client, err := c.getClient()
if err != nil {
return nil, err
}

return client.IndexDetail(ctx, &payload.Empty{})
}

func (c *client) getGRPCConn() (*grpc.ClientConn, error) {
return grpc.NewClient(
c.host+":"+strconv.Itoa(c.port),
Expand Down
Loading