Backport PR #2726 to release/v1.7 for fix not found error for gateway handler #2727

vdaas-ci · 2024-10-30T06:32:32Z

Description

SSIA

Related Issue

Versions

Vald Version: v1.7.13
Go Version: v1.23.2
Rust Version: v1.81.0
Docker Version: v27.3.1
Kubernetes Version: v1.31.1
Helm Version: v3.16.2
NGT Version: v2.2.4
Faiss Version: v1.9.0

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

Bug Fixes
- Improved error handling in MultiUpdate and MultiRemove methods for better error reporting.
- Enhanced error logging for clearer traceability of issues.
Refactor
- Streamlined error handling logic for improved readability and maintainability.

cloudflare-workers-and-pages · 2024-10-30T06:32:34Z

Deploying vald with Cloudflare Pages

Latest commit:	`4e9d76a`
Status:	✅ Deploy successful!
Preview URL:	https://557d67ee.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-bugfix-wfyh.vald.pages.dev

View logs

coderabbitai · 2024-10-30T06:32:41Z

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the pkg/gateway/lb/handler/grpc/handler.go file, focusing on enhancing error handling in the MultiUpdate and MultiRemove methods. The changes ensure that error states are derived from a cumulative error variable, improving clarity in error reporting. Additionally, the updates refine how errors are recorded in spans, aligning them with the new error handling structure. While the overall control flow remains unchanged, these improvements aim to bolster the robustness of error diagnostics and debugging.

Changes

File Path	Change Summary
pkg/gateway/lb/handler/grpc/handler.go	Updated error handling in `MultiUpdate` and `MultiRemove` methods to use cumulative error reporting; modified method signatures to reflect changes.

Possibly related PRs

Fix gRPC error msg handling for lb-gateway handler #2663: Fixes gRPC error message handling in the lb-gateway handler, directly related to the error handling improvements in this PR.
Backport PR #2663 to to release/v1.7 for Fix gRPC error msg handling for lb-gateway handler #2682: Backports changes from PR Fix gRPC error msg handling for lb-gateway handler #2663, reinforcing the connection to the main PR's modifications in error handling.
fix not found error for gateway handler #2726: Addresses error handling improvements specifically in MultiUpdate and MultiRemove methods, aligning with the focus of this PR.

Suggested labels

type/bug, priority/medium, size/S, area/gateway/lb, actions/backport/release/v1.7

Suggested reviewers

vankichi
kpango
datelier

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vdaas-ci · 2024-10-30T06:35:53Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4da0f33 and 4e9d76a.

📒 Files selected for processing (1)

pkg/gateway/lb/handler/grpc/handler.go (2 hunks)

🔇 Additional comments (2)

pkg/gateway/lb/handler/grpc/handler.go (2)

Line range hint 1-3000: Well-structured error handling patterns

The error handling patterns across the file are well-structured with:

Consistent error wrapping with appropriate status codes
Proper span recording with detailed error information
Good use of error context and resource details

Line range hint 1-3000: Well-implemented concurrency patterns

The concurrency handling throughout the file is well-implemented with:

Proper use of mutexes for protecting shared resources
Effective use of error groups for concurrent operations
Appropriate use of atomic operations for counters

pkg/gateway/lb/handler/grpc/handler.go

codecov · 2024-10-30T06:48:07Z

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.7@4da0f33). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/gateway/lb/handler/grpc/handler.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             release/v1.7    #2727   +/-   ##
===============================================
  Coverage                ?   23.95%           
===============================================
  Files                   ?      545           
  Lines                   ?    54322           
  Branches                ?        0           
===============================================
  Hits                    ?    13015           
  Misses                  ?    40531           
  Partials                ?      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix not found error (#2726)

4e9d76a

github-actions bot added area/gateway/lb size/XXXL labels Oct 30, 2024

github-actions bot added the priority/low label Oct 30, 2024

coderabbitai bot requested changes Oct 30, 2024

View reviewed changes

pkg/gateway/lb/handler/grpc/handler.go Show resolved Hide resolved

pkg/gateway/lb/handler/grpc/handler.go Show resolved Hide resolved

coderabbitai bot approved these changes Oct 30, 2024

View reviewed changes

vankichi approved these changes Oct 30, 2024

View reviewed changes

vankichi merged commit b8983ce into release/v1.7 Oct 30, 2024
46 of 48 checks passed

vankichi deleted the backport/release/v1.7/bugfix/gateway/fix-not-found branch October 30, 2024 07:27

github-actions bot mentioned this pull request Nov 1, 2024

Monthly review time metrics report: 2024-10-01..2024-10-31 #2728

Closed

coderabbitai bot mentioned this pull request Nov 11, 2024

Backport PR #2733 to release/v1.7 for [BUGFIX] resolve agent GetGraphStatistics API double-free error problem #2738

Closed

2 tasks

This was referenced Dec 3, 2024

[patch] Release v1.7.15 #2761

Closed

[patch] Release v1.7.15 #2763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport PR #2726 to release/v1.7 for fix not found error for gateway handler #2727

Backport PR #2726 to release/v1.7 for fix not found error for gateway handler #2727

vdaas-ci commented Oct 30, 2024 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Oct 30, 2024 •

edited

Loading

coderabbitai bot commented Oct 30, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vdaas-ci commented Oct 30, 2024

coderabbitai bot left a comment

codecov bot commented Oct 30, 2024

Backport PR #2726 to release/v1.7 for fix not found error for gateway handler #2727

Backport PR #2726 to release/v1.7 for fix not found error for gateway handler #2727

Conversation

vdaas-ci commented Oct 30, 2024 • edited by coderabbitai bot Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

cloudflare-workers-and-pages bot commented Oct 30, 2024 • edited Loading

Deploying vald with Cloudflare Pages

coderabbitai bot commented Oct 30, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vdaas-ci commented Oct 30, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 30, 2024

Codecov Report

vdaas-ci commented Oct 30, 2024 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Oct 30, 2024 •

edited

Loading

coderabbitai bot commented Oct 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)