Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2708 to release/v1.7 for fix: typo in index job #2711

Merged
merged 1 commit into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/gateway/mirror/usecase/vald.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/creation/service/indexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
switch {
case errors.Is(err, context.Canceled):
err = status.WrapWithCanceled(
agent.CreateIndexRPCName+" API canceld", err,
agent.CreateIndexRPCName+" API canceled", err,

Check warning on line 178 in pkg/index/job/creation/service/indexer.go

View check run for this annotation

Codecov / codecov/patch

pkg/index/job/creation/service/indexer.go#L178

Added line #L178 was not covered by tests
)
attrs = trace.StatusCodeCancelled(err.Error())
case errors.Is(err, context.DeadlineExceeded):
Expand Down
2 changes: 1 addition & 1 deletion pkg/index/job/creation/usecase/creation.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/readreplica/rotate/usecase/rotate.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/save/service/indexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
switch {
case errors.Is(err, context.Canceled):
err = status.WrapWithCanceled(
agent.SaveIndexRPCName+" API canceld", err,
agent.SaveIndexRPCName+" API canceled", err,

Check warning on line 174 in pkg/index/job/save/service/indexer.go

View check run for this annotation

Codecov / codecov/patch

pkg/index/job/save/service/indexer.go#L174

Added line #L174 was not covered by tests
)
attrs = trace.StatusCodeCancelled(err.Error())
case errors.Is(err, context.DeadlineExceeded):
Expand Down
2 changes: 1 addition & 1 deletion pkg/index/job/save/usecase/save.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/operator/usecase/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
Loading