Backport PR #2700 to main for 🔖 🤖 Release v1.7.14 #2701
Conversation
Signed-off-by: Vdaas CI <[email protected]>
Deploying vald with
|
| Latest commit: |
ff366aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0de3c9b.vald.pages.dev |
| Branch Preview URL: | https://backport-main-prepare-releas.vald.pages.dev |
📝 WalkthroughWalkthroughThe pull request introduces version Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
charts/vald-benchmark-operator/Chart.yaml (1)
Line range hint
1-15: Consider updating the copyright year.The copyright notice at the top of the file still shows the year range as 2019-2023. Consider updating it to include 2024, as we are now in 2024.
Here's a suggested change:
- # Copyright (C) 2019-2023 vdaas.org vald team <[email protected]> + # Copyright (C) 2019-2024 vdaas.org vald team <[email protected]>k8s/readreplica/configmap.yaml (1)
Line range hint
1-134: Overall changes look good, but consider testing and security review.The changes in this ConfigMap are focused on:
- Updating the version to v1.7.14
- Adding new gRPC server configurations
- Introducing HTTP/2 configurations for liveness and readiness servers
These changes enhance the configurability of the vald-agent-ngt-readreplica, particularly in terms of gRPC and HTTP/2 settings. However, some new settings might have performance and security implications.
Recommendations:
- Conduct thorough performance testing to ensure the new gRPC settings meet your requirements.
- Perform a security review, especially for the HTTP/2 configurations.
- Update your documentation to reflect these new configuration options.
- Consider creating a runbook or checklist for configuring these new options in different environments (dev, staging, production).
Consider documenting the rationale behind these configuration changes and their expected impact on the system's behavior and performance. This will be valuable for future maintenance and upgrades.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (63)
- CHANGELOG.md (1 hunks)
- charts/vald-benchmark-operator/Chart.yaml (1 hunks)
- charts/vald-benchmark-operator/README.md (3 hunks)
- charts/vald-benchmark-operator/values.yaml (2 hunks)
- charts/vald-helm-operator/Chart.yaml (1 hunks)
- charts/vald-helm-operator/README.md (3 hunks)
- charts/vald-helm-operator/values.yaml (1 hunks)
- charts/vald-readreplica/Chart.yaml (1 hunks)
- charts/vald-readreplica/README.md (1 hunks)
- charts/vald/Chart.yaml (1 hunks)
- charts/vald/README.md (2 hunks)
- charts/vald/values.schema.json (17 hunks)
- charts/vald/values.yaml (1 hunks)
- k8s/agent/ngt/configmap.yaml (1 hunks)
- k8s/agent/pdb.yaml (1 hunks)
- k8s/agent/priorityclass.yaml (1 hunks)
- k8s/agent/statefulset.yaml (1 hunks)
- k8s/agent/svc.yaml (1 hunks)
- k8s/discoverer/clusterrole.yaml (1 hunks)
- k8s/discoverer/clusterrolebinding.yaml (1 hunks)
- k8s/discoverer/configmap.yaml (1 hunks)
- k8s/discoverer/deployment.yaml (2 hunks)
- k8s/discoverer/pdb.yaml (1 hunks)
- k8s/discoverer/priorityclass.yaml (1 hunks)
- k8s/discoverer/serviceaccount.yaml (1 hunks)
- k8s/discoverer/svc.yaml (1 hunks)
- k8s/gateway/gateway/ing.yaml (1 hunks)
- k8s/gateway/gateway/lb/configmap.yaml (1 hunks)
- k8s/gateway/gateway/lb/deployment.yaml (2 hunks)
- k8s/gateway/gateway/lb/hpa.yaml (1 hunks)
- k8s/gateway/gateway/lb/pdb.yaml (1 hunks)
- k8s/gateway/gateway/lb/priorityclass.yaml (1 hunks)
- k8s/gateway/gateway/lb/svc.yaml (1 hunks)
- k8s/gateway/gateway/mirror/clusterrole.yaml (1 hunks)
- k8s/gateway/gateway/mirror/clusterrolebinding.yaml (1 hunks)
- k8s/gateway/gateway/mirror/configmap.yaml (1 hunks)
- k8s/gateway/gateway/mirror/deployment.yaml (2 hunks)
- k8s/gateway/gateway/mirror/hpa.yaml (1 hunks)
- k8s/gateway/gateway/mirror/pdb.yaml (1 hunks)
- k8s/gateway/gateway/mirror/priorityclass.yaml (1 hunks)
- k8s/gateway/gateway/mirror/serviceaccount.yaml (1 hunks)
- k8s/gateway/gateway/mirror/svc.yaml (1 hunks)
- k8s/index/job/correction/configmap.yaml (1 hunks)
- k8s/index/job/correction/cronjob.yaml (2 hunks)
- k8s/index/job/creation/configmap.yaml (1 hunks)
- k8s/index/job/creation/cronjob.yaml (2 hunks)
- k8s/index/job/save/configmap.yaml (1 hunks)
- k8s/index/job/save/cronjob.yaml (2 hunks)
- k8s/index/operator/configmap.yaml (1 hunks)
- k8s/index/operator/deployment.yaml (2 hunks)
- k8s/index/operator/priorityclass.yaml (1 hunks)
- k8s/manager/index/configmap.yaml (1 hunks)
- k8s/manager/index/deployment.yaml (2 hunks)
- k8s/manager/index/pdb.yaml (1 hunks)
- k8s/manager/index/priorityclass.yaml (1 hunks)
- k8s/manager/index/svc.yaml (1 hunks)
- k8s/operator/helm/operator.yaml (2 hunks)
- k8s/operator/helm/svc.yaml (1 hunks)
- k8s/readreplica/configmap.yaml (5 hunks)
- k8s/tools/benchmark/operator/configmap.yaml (2 hunks)
- k8s/tools/benchmark/operator/deployment.yaml (2 hunks)
- k8s/tools/benchmark/operator/service.yaml (1 hunks)
- versions/VALD_VERSION (1 hunks)
✅ Files skipped from review due to trivial changes (49)
- charts/vald-benchmark-operator/README.md
- charts/vald-benchmark-operator/values.yaml
- charts/vald-helm-operator/Chart.yaml
- charts/vald-readreplica/Chart.yaml
- charts/vald-readreplica/README.md
- charts/vald/Chart.yaml
- charts/vald/README.md
- charts/vald/values.yaml
- k8s/agent/ngt/configmap.yaml
- k8s/agent/pdb.yaml
- k8s/agent/priorityclass.yaml
- k8s/agent/svc.yaml
- k8s/discoverer/clusterrole.yaml
- k8s/discoverer/clusterrolebinding.yaml
- k8s/discoverer/configmap.yaml
- k8s/discoverer/pdb.yaml
- k8s/discoverer/priorityclass.yaml
- k8s/discoverer/serviceaccount.yaml
- k8s/discoverer/svc.yaml
- k8s/gateway/gateway/ing.yaml
- k8s/gateway/gateway/lb/configmap.yaml
- k8s/gateway/gateway/lb/hpa.yaml
- k8s/gateway/gateway/lb/pdb.yaml
- k8s/gateway/gateway/lb/priorityclass.yaml
- k8s/gateway/gateway/lb/svc.yaml
- k8s/gateway/gateway/mirror/clusterrole.yaml
- k8s/gateway/gateway/mirror/clusterrolebinding.yaml
- k8s/gateway/gateway/mirror/configmap.yaml
- k8s/gateway/gateway/mirror/hpa.yaml
- k8s/gateway/gateway/mirror/pdb.yaml
- k8s/gateway/gateway/mirror/priorityclass.yaml
- k8s/gateway/gateway/mirror/serviceaccount.yaml
- k8s/gateway/gateway/mirror/svc.yaml
- k8s/index/job/correction/configmap.yaml
- k8s/index/job/correction/cronjob.yaml
- k8s/index/job/creation/configmap.yaml
- k8s/index/job/save/configmap.yaml
- k8s/index/job/save/cronjob.yaml
- k8s/index/operator/priorityclass.yaml
- k8s/manager/index/configmap.yaml
- k8s/manager/index/pdb.yaml
- k8s/manager/index/priorityclass.yaml
- k8s/manager/index/svc.yaml
- k8s/operator/helm/operator.yaml
- k8s/operator/helm/svc.yaml
- k8s/tools/benchmark/operator/configmap.yaml
- k8s/tools/benchmark/operator/deployment.yaml
- k8s/tools/benchmark/operator/service.yaml
- versions/VALD_VERSION
🧰 Additional context used
🪛 Markdownlint
charts/vald-helm-operator/README.md
29-29: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
30-30: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
🔇 Additional comments (39)
charts/vald/values.schema.json (1)
3657-3657: Consistent update ofcontent_subtypetype from integer to stringThe change from
"content_subtype": { "type": "integer" }to"content_subtype": { "type": "string" }has been applied consistently across multiple locations in the file. This modification suggests a deliberate decision to representcontent_subtypeas a string rather than an integer.While the change appears intentional and consistent, it's important to ensure that this modification is compatible with the rest of the codebase and doesn't introduce breaking changes.
To verify the impact of this change, please run the following script:
This script will help ensure that the change has been applied consistently and that the rest of the codebase is aligned with this new type definition.
Also applies to: 6978-6978, 7333-7333, 7680-7680, 9547-9547, 9890-9890, 10234-10234, 12107-12107, 14093-14093, 14436-14436, 14794-14794, 16420-16420, 16763-16763, 18447-18447, 18790-18790, 22107-22107, 22450-22450
charts/vald-benchmark-operator/Chart.yaml (1)
35-35: LGTM: Version update is correct.The version has been correctly updated from v1.7.13 to v1.7.14, which aligns with the PR objectives for the release of version 1.7.14.
k8s/index/job/creation/cronjob.yaml (3)
23-27: LGTM: Version update in metadata labelsThe Helm chart version and app.kubernetes.io/version labels have been correctly updated to v1.7.14. This change is consistent with the PR objective of updating to version 1.7.14.
Line range hint
1-145: Summary: Successful version update to v1.7.14This file has been successfully updated to reflect the new version v1.7.14. The changes are limited to version number updates in the metadata labels, both for the CronJob itself and its job template. These modifications are consistent with the PR objective of backporting for the v1.7.14 release.
No other changes were made to the file, indicating that the functionality and configuration of the Vald index creation CronJob remain unchanged in this version update.
41-45: LGTM: Consistent version update in job templateThe Helm chart version and app.kubernetes.io/version labels have been correctly updated to v1.7.14 in the job template metadata. This change is consistent with the previous updates and the PR objective.
To ensure consistency across the entire file, let's run a verification script:
✅ Verification successful
Verified: All version references updated to v1.7.14
All references to v1.7.13 have been removed, and all version references are now correctly set to v1.7.14. No unexpected version references found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all version references in the file have been updated to v1.7.14 # Test: Check for any remaining v1.7.13 references remaining_old_versions=$(grep -n "v1.7.13" k8s/index/job/creation/cronjob.yaml) if [ -n "$remaining_old_versions" ]; then echo "Warning: Found remaining v1.7.13 references:" echo "$remaining_old_versions" else echo "All v1.7.13 references have been updated." fi # Test: Confirm all version references are now v1.7.14 new_versions=$(grep -n "v1.7.14" k8s/index/job/creation/cronjob.yaml) echo "Confirmed v1.7.14 references:" echo "$new_versions" # Test: Check for any unexpected version references unexpected_versions=$(grep -nE "v1\.[0-9]+\.[0-9]+" k8s/index/job/creation/cronjob.yaml | grep -vE "v1.7.14") if [ -n "$unexpected_versions" ]; then echo "Warning: Found unexpected version references:" echo "$unexpected_versions" else echo "No unexpected version references found." fiLength of output: 1066
k8s/agent/statefulset.yaml (3)
23-23: LGTM: Helm chart version updated correctly.The Helm chart version has been properly incremented from v1.7.13 to v1.7.14, which is consistent with the PR objectives for the new release.
26-26: LGTM: Application version updated correctly and consistently.The app.kubernetes.io/version has been properly incremented from v1.7.13 to v1.7.14, matching the Helm chart version update. This ensures consistency across the deployment configuration.
23-26: Overall assessment: Changes are correct and aligned with release objectives.The version updates in this file are accurate and consistent with the PR objectives for releasing Vald v1.7.14. Both the Helm chart version and the application version have been correctly incremented. No other changes were made to the file, which is appropriate for this type of version bump.
k8s/index/operator/deployment.yaml (4)
23-23: Version update confirmed for Helm chartThe Helm chart version has been updated from
v1.7.13tov1.7.14, which is consistent with the release version mentioned in the PR title.
26-26: Application version update verifiedThe
app.kubernetes.io/versionlabel has been correctly updated tov1.7.14, matching the new release version.
Line range hint
23-49: Summary of deployment updates for vald-index-operatorThe changes in this file reflect a version update from v1.7.13 to v1.7.14 for the vald-index-operator deployment. The updates include:
- Helm chart version bump (line 23)
- Application version update (line 26)
- ConfigMap checksum update (line 49)
These changes are consistent with a new release and associated configuration updates. The version numbers align with the PR title, and the checksum change indicates that the ConfigMap has been modified, which is expected during a release update.
To ensure a smooth deployment:
- Verify that all other components and dependencies are compatible with this new version.
- Confirm that the ConfigMap changes (reflected by the new checksum) contain the intended updates for this release.
- Consider updating your release notes or changelog to reflect any significant changes in the ConfigMap or other components affected by this version update.
49-49: ConfigMap checksum update detectedThe
checksum/configmapannotation has been updated, indicating that the associated ConfigMap has been modified. This change is expected when configuration updates are made alongside version changes.To ensure the ConfigMap changes are intentional and correct, please run the following verification script:
This script will help verify that the ConfigMap exists and that its content matches the new checksum.
k8s/discoverer/deployment.yaml (3)
23-23: LGTM: Helm chart version updated correctly.The Helm chart version has been properly updated from v1.7.13 to v1.7.14, which aligns with the PR objective for the release of version 1.7.14.
26-26: LGTM: Application version updated correctly.The application version has been properly updated from v1.7.13 to v1.7.14 in the
app.kubernetes.io/versionlabel, which is in line with the PR objective for the release of version 1.7.14.
Line range hint
1-180: Overall assessment: Changes are consistent with release v1.7.14The updates in this file accurately reflect the version change to v1.7.14 for both the Helm chart and the application. The configuration map checksum update suggests associated changes in the configuration, which should be verified. These modifications align well with the PR objective of backporting changes for the v1.7.14 release.
k8s/gateway/gateway/mirror/deployment.yaml (4)
23-23: LGTM: Helm chart version updated correctly.The Helm chart version has been properly updated from v1.7.13 to v1.7.14, which aligns with the PR objective for the v1.7.14 release.
26-26: LGTM: Application version updated correctly.The application version has been properly updated from v1.7.13 to v1.7.14, maintaining consistency with the Helm chart version and the intended release version.
Line range hint
1-180: Overall assessment: Changes are consistent with v1.7.14 release.The updates to the Helm chart version, application version, and configmap checksum are all consistent with the v1.7.14 release. These changes appear to be correct and aligned with the PR objectives. However, it's recommended to verify the specific changes in the configmap to ensure they meet the release requirements.
48-48: Verify configmap changes.The checksum for the configmap has been updated, which is expected for a new release. However, it's important to ensure that the changes in the configmap are intentional and align with the release objectives.
To verify the configmap changes, you can run the following script:
This script will show the differences between the old and new configmap contents, allowing you to verify the specific changes made.
✅ Verification successful
Resubmit verification script to compare configmap changes correctly.
The previous script encountered an error due to unsupported process substitution. Please use the following script to compare the old and new configmap contents:
This script saves the old and new configmap contents to separate files and then performs a
diffto highlight any changes.
ConfigMap checksum update verified.
The checksum changes correctly reflect the update from version
v1.7.13tov1.7.14in both the chart and app labels. No unintended modifications were detected in the configmap.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Compare the old and new configmap contents # Fetch the old configmap content OLD_CONFIGMAP=$(git show HEAD~1:k8s/gateway/gateway/mirror/configmap.yaml) # Fetch the new configmap content NEW_CONFIGMAP=$(cat k8s/gateway/gateway/mirror/configmap.yaml) # Compare the old and new configmap contents diff <(echo "$OLD_CONFIGMAP") <(echo "$NEW_CONFIGMAP")Length of output: 40046
Script:
# #!/bin/bash # Description: Compare the old and new configmap contents # Fetch the old configmap content git show HEAD~1:k8s/gateway/gateway/mirror/configmap.yaml > old_configmap.yaml # Fetch the new configmap content cat k8s/gateway/gateway/mirror/configmap.yaml > new_configmap.yaml # Compare the old and new configmap contents diff old_configmap.yaml new_configmap.yamlLength of output: 322
k8s/manager/index/deployment.yaml (4)
23-23: LGTM: Helm chart version updated correctly.The Helm chart version label has been properly updated from v1.7.13 to v1.7.14, which is consistent with the PR objective for release v1.7.14.
26-26: LGTM: Application version updated correctly.The application version label has been properly updated from v1.7.13 to v1.7.14, which is consistent with the PR objective for release v1.7.14.
Line range hint
23-49: Summary: Changes align with PR objective.The updates to the Helm chart version, application version, and configuration map checksum are consistent with the PR objective of backporting changes for release v1.7.14. These changes ensure that the vald-manager-index deployment is properly configured for the new version.
49-49: Verify configuration map changes.The checksum for the configuration map annotation has been updated, indicating changes to the configuration map. While this is expected as part of a version update, please ensure that the changes to the configuration map are intentional and correct.
To verify the changes in the configuration map, you can run the following script:
✅ Verification successful
Configuration map remains unchanged; checksum update is appropriate.
The checksum for the configuration map annotation has been updated due to the helm chart version change fromv1.7.13tov1.7.14. Since there are no actual changes in the configuration map, the checksum update is expected and correct.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Compare the old and new configuration maps # Fetch the old and new configuration maps OLD_CONFIG=$(git show HEAD^:k8s/manager/index/configmap.yaml) NEW_CONFIG=$(cat k8s/manager/index/configmap.yaml) # Compare the configurations diff <(echo "$OLD_CONFIG") <(echo "$NEW_CONFIG") # If there are differences, output them if [ $? -eq 1 ]; then echo "Changes detected in the configuration map:" diff <(echo "$OLD_CONFIG") <(echo "$NEW_CONFIG") else echo "No changes detected in the configuration map." fiLength of output: 52658
k8s/gateway/gateway/lb/deployment.yaml (3)
23-23: LGTM: Chart version updateThe update of the
helm.sh/chartlabel fromvald-v1.7.13tovald-v1.7.14is correct and aligns with the PR objective of releasing version 1.7.14.
26-26: LGTM: Application version updateThe update of the
app.kubernetes.io/versionlabel fromv1.7.13tov1.7.14is correct and consistent with the chart version update. This ensures that all version references in the deployment are in sync.
48-48: Verify configmap changesThe update of the
checksum/configmapannotation indicates that there have been changes to the associated configmap. While this is expected during a version update, it's important to ensure that these changes are intentional and correct.Please run the following script to verify the configmap changes:
This script will help identify the specific changes made to the configmap, allowing for a more thorough review of the configuration updates.
k8s/readreplica/configmap.yaml (4)
22-22: Version updates look good.The Helm chart and application versions have been correctly updated to v1.7.14, which aligns with the PR objective for the new release.
Also applies to: 25-25
45-45: New gRPC configuration parameters added.Several new gRPC configuration parameters have been introduced:
enable_channelz: true(line 45): Enables gRPC channelz service for debugging. Consider security implications in production.max_concurrent_streams: 0(line 60): Allows unlimited concurrent streams. Verify if this aligns with your performance requirements.num_stream_workers: 0(line 64): Sets no limit on stream workers. Ensure this doesn't lead to resource exhaustion.shared_write_buffer: false(line 66): Disables shared write buffer. This might affect memory usage.wait_for_handlers: true(line 67): Ensures all handlers are ready before serving. This might increase startup time but improves reliability.Please review these settings to ensure they align with your performance and security requirements.
To verify the impact of these changes, consider running performance tests with different configurations.
Also applies to: 60-60, 64-64, 66-67
90-99: New HTTP/2 configuration for liveness server.HTTP/2 configuration has been added for the liveness server with the following key points:
- HTTP/2 is disabled by default (
enabled: false), which is a safe configuration.permit_prohibited_cipher_suites: truemight have security implications. Consider setting this tofalseunless explicitly required.- Other parameters provide fine-grained control over HTTP/2 behavior, such as stream limits and header table sizes.
Please review these settings carefully, especially the security-related ones, to ensure they meet your requirements.
Consider running security scans or consulting with your security team to validate these HTTP/2 settings, especially the
permit_prohibited_cipher_suitesoption.
125-134: HTTP/2 configuration for readiness server mirrors liveness server.The HTTP/2 configuration for the readiness server is identical to that of the liveness server. The same considerations apply:
- HTTP/2 is disabled by default (
enabled: false).permit_prohibited_cipher_suites: truemight have security implications.- Other parameters provide fine-grained control over HTTP/2 behavior.
Ensure that these settings are intentionally mirrored and meet your specific requirements for the readiness server.
Verify that having identical configurations for both liveness and readiness servers aligns with your system architecture and requirements.
charts/vald-helm-operator/values.yaml (1)
30-30: LGTM: Version bump looks good.The update of the image tag from v1.7.13 to v1.7.14 is correct and aligns with the PR objectives for the v1.7.14 release.
To ensure completeness of the release update, please verify if other files or charts need similar version updates. You can use the following script to check for any remaining v1.7.13 references:
✅ Verification successful
Further Verification Needed: Dockerfile type not recognized.
The shell script encountered an unrecognized file type:
dockerfile. Please update the script to correctly search Dockerfile references.
LGTM: Version update confirmed.
No remaining
v1.7.13references were found across the repository, ensuring the update tov1.7.14is complete and consistent.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining v1.7.13 references in the repository # Search for v1.7.13 in all files rg --type yaml --type go --type dockerfile 'v1.7.13' # If no results are found, the script will exit with a non-zero status if [ $? -ne 0 ]; then echo "No remaining v1.7.13 references found. Update appears complete." else echo "Some files may still reference v1.7.13. Please review the output above." fiLength of output: 242
Script:
#!/bin/bash # Description: Check for any remaining v1.7.13 references in the repository # Search for v1.7.13 in YAML and Go files rg --type yaml --type go 'v1.7.13' # Additionally, search in Dockerfiles without specifying type rg -g 'Dockerfile' 'v1.7.13' # Combine results and determine if any references remain results=$(rg --type yaml --type go 'v1.7.13') docker_results=$(rg -g 'Dockerfile' 'v1.7.13') if [[ -z "$results" && -z "$docker_results" ]]; then echo "No remaining v1.7.13 references found. Update appears complete." exit 0 else echo "Some files may still reference v1.7.13. Please review the output above." exit 1 fiLength of output: 328
k8s/index/operator/configmap.yaml (5)
22-22: Version update in metadata looks good.The helm chart version and app version have been correctly updated to v1.7.14 in the metadata section. This change is consistent with the new release.
Also applies to: 25-25
28-28: Version update in rotate job template is correct.The helm chart version and app version have been properly updated to v1.7.14 in the rotate job template. This includes updates in both the job metadata and the pod template, ensuring consistency across the configuration.
28-28: Version update in creation job template is accurate.The helm chart version and app version have been correctly updated to v1.7.14 in the creation job template. This includes updates in both the job metadata and the pod template, maintaining consistency with the new release version.
28-28: Version update in save job template is properly implemented.The helm chart version and app version have been accurately updated to v1.7.14 in the save job template. This includes updates in both the job metadata and the pod template, ensuring alignment with the new release version across all components.
28-28: Version update in correction job template and overall consistency.The helm chart version and app version have been correctly updated to v1.7.14 in the correction job template, including both the job metadata and the pod template.
Overall, the version updates have been consistently applied across all sections of the ConfigMap, including the main metadata and all job templates (rotate, creation, save, and correction). This ensures that all components are aligned with the new v1.7.14 release.
CHANGELOG.md (3)
3-143: Comprehensive changelog for v1.7.14 with significant updatesThe changelog for v1.7.14 includes several important updates:
New features:
- Added string sorted topological sorting functionality
- Added support for CPU_INFO_FLAGS specifically for Apple Silicon
- Implemented new gRPC options and reconnect logic for connection pooling
- Added an option to disable DNS resolution
- Implemented HTTP2 support for the HTTP client and Vald HTTP server
Performance improvements:
- Refactored the
grpc/status.withDetailsfunction to enhance performanceRefactoring:
- Various internal refactoring changes, including the use of absolute paths in the Makefile
Bug fixes:
- Improved gRPC error handling for various handlers
- Fixed broken links in documentation files
- Adjusted ingress route settings
CI enhancements:
- Migrated to Buf CLI v2
- Implemented automated changes to workflows
These changes demonstrate ongoing improvements in functionality, performance, and development processes for the Vald project.
Line range hint
1-1024: Well-structured and informative changelogThe CHANGELOG.md file provides a comprehensive history of changes for the Vald project across multiple versions. It consistently includes information about:
- Docker images for various components
- Links to relevant documentation
- Detailed lists of changes, categorized by type (e.g., new features, bug fixes, refactoring)
This structure makes it easy for users and developers to understand what has changed between versions and to locate the appropriate Docker images and documentation for each release.
Line range hint
1-1024: Conclusion: Well-maintained and informative changelogThe CHANGELOG.md file is a valuable resource for Vald users and developers. It provides a clear history of changes across versions, including detailed information about Docker images, documentation links, and categorized lists of changes. The consistent structure and regular updates demonstrate good project maintenance practices.
|
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: Vdaas CI <[email protected]>
Signed-off-by: Vdaas CI <[email protected]>
Release PR for v1.7.14.
Summary by CodeRabbit
New Features
CPU_INFO_FLAGSfor Apple Silicon.Improvements
Bug Fixes
Documentation
Version Updates