Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2639 to release/v1.7 for Refctor for release v1.7.14 #2648

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Backport PR #2639 to release/v1.7 for Refctor for release v1.7.14 #2648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .gitfiles
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
.github/workflows/chatops-help.yaml
.github/workflows/chatops.yaml
.github/workflows/check-conflict.yaml
.github/workflows/codeql-analysis.yaml
.github/workflows/codeql-analysis.yml
.github/workflows/coverage.yaml
.github/workflows/detect-internal-config-changes.yaml
.github/workflows/dockers-agent-faiss-image.yaml
Expand Down Expand Up @@ -167,6 +167,8 @@ apis/grpc/v1/filter/egress/egress_filter.pb.go
apis/grpc/v1/filter/egress/egress_filter_vtproto.pb.go
apis/grpc/v1/filter/ingress/ingress_filter.pb.go
apis/grpc/v1/filter/ingress/ingress_filter_vtproto.pb.go
apis/grpc/v1/meta/meta.pb.go
apis/grpc/v1/meta/meta_vtproto.pb.go
apis/grpc/v1/mirror/mirror.go
apis/grpc/v1/mirror/mirror.pb.go
apis/grpc/v1/mirror/mirror_vtproto.pb.go
Expand Down Expand Up @@ -203,6 +205,7 @@ apis/proto/v1/agent/sidecar/sidecar.proto
apis/proto/v1/discoverer/discoverer.proto
apis/proto/v1/filter/egress/egress_filter.proto
apis/proto/v1/filter/ingress/ingress_filter.proto
apis/proto/v1/meta/meta.proto
kpango marked this conversation as resolved.
Show resolved Hide resolved
apis/proto/v1/mirror/mirror.proto
apis/proto/v1/payload/payload.proto
apis/proto/v1/rpc/errdetails/error_details.proto
Expand All @@ -220,6 +223,7 @@ apis/swagger/v1/agent/sidecar/sidecar.swagger.json
apis/swagger/v1/discoverer/discoverer.swagger.json
apis/swagger/v1/filter/egress/egress_filter.swagger.json
apis/swagger/v1/filter/ingress/ingress_filter.swagger.json
apis/swagger/v1/meta/meta.swagger.json
apis/swagger/v1/mirror/mirror.swagger.json
apis/swagger/v1/payload/payload.swagger.json
apis/swagger/v1/rpc/errdetails/error_details.swagger.json
Expand Down Expand Up @@ -882,6 +886,9 @@ internal/core/algorithm/ngt/ngt_bench_test.go
internal/core/algorithm/ngt/ngt_test.go
internal/core/algorithm/ngt/option.go
internal/core/algorithm/ngt/option_test.go
internal/core/algorithm/usearch/option.go
internal/core/algorithm/usearch/usearch.go
internal/core/algorithm/usearch/usearch_test.go
kpango marked this conversation as resolved.
Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go
internal/db/kvs/bbolt/bbolt_test.go
internal/db/kvs/bbolt/option.go
Expand Down Expand Up @@ -1024,6 +1031,7 @@ internal/errors/storage.go
internal/errors/tls.go
internal/errors/unit.go
internal/errors/unit_test.go
internal/errors/usearch.go
internal/errors/vald.go
internal/errors/vald_test.go
internal/errors/vqueue.go
Expand Down Expand Up @@ -1911,6 +1919,10 @@ rust/bin/agent/src/handler/search.rs
rust/bin/agent/src/handler/update.rs
rust/bin/agent/src/handler/upsert.rs
rust/bin/agent/src/main.rs
rust/bin/meta/Cargo.toml
rust/bin/meta/src/handler.rs
rust/bin/meta/src/handler/meta.rs
rust/bin/meta/src/main.rs
rust/libs/algorithm/Cargo.toml
rust/libs/algorithm/src/lib.rs
rust/libs/algorithms/faiss/Cargo.toml
Expand All @@ -1931,6 +1943,7 @@ rust/libs/proto/src/discoverer.v1.tonic.rs
rust/libs/proto/src/filter.egress.v1.tonic.rs
rust/libs/proto/src/filter.ingress.v1.tonic.rs
rust/libs/proto/src/lib.rs
rust/libs/proto/src/meta.v1.tonic.rs
rust/libs/proto/src/mirror.v1.tonic.rs
rust/libs/proto/src/payload.v1.rs
rust/libs/proto/src/rpc.v1.rs
Expand Down Expand Up @@ -1986,6 +1999,7 @@ versions/PROTOBUF_VERSION
versions/REVIEWDOG_VERSION
versions/RUST_VERSION
versions/TELEPRESENCE_VERSION
versions/USEARCH_VERSION
versions/VALD_VERSION
versions/YQ_VERSION
versions/ZLIB_VERSION
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ assignees: ""
- Vald Version: v1.7.13
- Go Version: v1.23.1
- Rust Version: v1.81.0
- Docker Version: v27.2.1
- Kubernetes Version: v1.31.0
- Helm Version: v3.16.0
- Docker Version: v27.3.1
- Kubernetes Version: v1.31.1
- Helm Version: v3.16.1
- NGT Version: v2.2.4
- Faiss Version: v1.8.0
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/security_issue_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ assignees: ""
- Vald Version: v1.7.13
- Go Version: v1.23.1
- Rust Version: v1.81.0
- Docker Version: v27.2.1
- Kubernetes Version: v1.31.0
- Helm Version: v3.16.0
- Docker Version: v27.3.1
- Kubernetes Version: v1.31.1
- Helm Version: v3.16.1
Comment on lines +22 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider a more maintainable approach for version numbers in templates

While updating the version numbers for Docker, Kubernetes, and Helm is good for keeping the template current, there are a couple of points to consider:

  1. The Vald version (v1.7.13) hasn't been updated, although the PR objectives mention refactoring for release v1.7.14. This inconsistency might lead to confusion.

  2. Frequently updating version numbers in issue templates can become a maintenance burden and may lead to outdated information if not regularly maintained.

Consider the following approaches:

  1. Use placeholder text for versions that change frequently, e.g., Docker Version: vX.Y.Z. This allows users to fill in the current version when reporting an issue.

  2. Alternatively, if you want to keep specific versions, implement an automated process to update these templates when new releases are made.

  3. Update the Vald version to v1.7.14 to align with the PR objectives, or clarify why it should remain at v1.7.13.

Example of using placeholder text:

- Docker Version: v27.3.1
- Kubernetes Version: v1.31.1
- Helm Version: v3.16.1
+ Docker Version: vX.Y.Z
+ Kubernetes Version: vX.Y.Z
+ Helm Version: vX.Y.Z

This approach would reduce the need for frequent updates to the template while still prompting users to provide their specific environment details.

Committable suggestion was skipped due to low confidence.

- NGT Version: v2.2.4
- Faiss Version: v1.8.0
10 changes: 5 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
### Description

<!-- Describe your changes in detail -->
<!-- It would be better to describe the details especially What changed and Why you changed -->
<!-- It would be better to describe the details, especially What changed and Why you changed -->

### Related Issue

Expand All @@ -18,9 +18,9 @@
- Vald Version: v1.7.13
- Go Version: v1.23.1
- Rust Version: v1.81.0
- Docker Version: v27.2.1
- Kubernetes Version: v1.31.0
- Helm Version: v3.16.0
- Docker Version: v27.3.1
- Kubernetes Version: v1.31.1
- Helm Version: v3.16.1
- NGT Version: v2.2.4
- Faiss Version: v1.8.0

Expand All @@ -34,4 +34,4 @@

### Special notes for your reviewer

<!-- Please tell us anything you would like to share to reviewers related this PR -->
<!-- Please tell us anything you would like to share with reviewers related to this PR. Your thoughts and feedback are highly valued -->
0 .github/workflows/codeql-analysis.yaml → .github/workflows/codeql-analysis.yml
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions .github/workflows/e2e-profiling.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,14 @@ jobs:
values: .github/helm/values/values-profile.yaml
wait_for_selector: app=vald-lb-gateway
- name: Deploy profefe
shell: bash
run: |
make k8s/metrics/profefe/deploy
kubectl patch cronjob kprofefe -p '{"spec": {"schedule": "*/1 * * * *"}}'
kubectl wait --for=condition=ready pod -l app=profefe --timeout=300s
- name: Run E2E CRUD
continue-on-error: true
shell: bash
run: |
make hack/benchmark/assets/dataset/${{ env.DATASET }}
make E2E_BIND_PORT=8081 \
Expand All @@ -83,6 +85,7 @@ jobs:
env:
POD_NAME: ${{ steps.deploy_vald.outputs.POD_NAME }}
- name: Get profiles
shell: bash
run: |
mkdir -p profiles
kubectl port-forward deployment/profefe 10100:10100 &
Expand Down Expand Up @@ -151,6 +154,7 @@ jobs:
path: graphs/*
- name: Upload to vald-ci-images repository
if: github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-profiling'
shell: bash
run: |
CLONE_DIR=$(mktemp -d)
git clone --depth 1 https://${GITHUB_USER}:${GITHUB_TOKEN}@github.com/vdaas-ci/vald-ci-images.git $CLONE_DIR
Expand All @@ -166,6 +170,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }}
- name: Comment
if: github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-profiling'
shell: bash
run: |
base="https://raw.githubusercontent.com/vdaas-ci/vald-ci-images/main/${GITHUB_SHA::6}"
body="<table><tr><th>type</th>"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:
E2E_UPDATE_COUNT=10 \
E2E_UPSERT_COUNT=10 \
E2E_REMOVE_COUNT=10 \
E2E_WAIT_FOR_CREATE_INDEX_DURATION=3m \
E2E_WAIT_FOR_CREATE_INDEX_DURATION=5m \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistency Detected in E2E_WAIT_FOR_CREATE_INDEX_DURATION Across Jobs

The E2E_WAIT_FOR_CREATE_INDEX_DURATION is set to 5m in the e2e-stream-crud-skip-exist-check job but remains at 3m in other jobs. To ensure consistency and prevent potential timeout issues across all E2E tests, please update the duration to 5m in the following jobs:

  • e2e-stream-crud
  • e2e-stream-crud-for-operator
  • e2e-stream-crud-under-index-management-jobs
🔗 Analysis chain

Approved: Increased wait time for index creation in e2e-stream-crud-skip-exist-check job.

Extending the E2E_WAIT_FOR_CREATE_INDEX_DURATION from 3 minutes to 5 minutes is a good adjustment. This change should help reduce potential false negatives in the E2E tests caused by timeout issues during index creation.

However, it's worth considering whether this change should be applied to other jobs in the workflow that use the same parameter. For consistency and to prevent similar timeout issues, you might want to update the duration in other jobs such as e2e-stream-crud, e2e-stream-crud-for-operator, and e2e-stream-crud-under-index-management-jobs.

To check for consistency across jobs, you can run the following command:

This will help identify which jobs might need to be updated for consistency.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of E2E_WAIT_FOR_CREATE_INDEX_DURATION across jobs

echo "Jobs with E2E_WAIT_FOR_CREATE_INDEX_DURATION set to 3m:"
grep -n "E2E_WAIT_FOR_CREATE_INDEX_DURATION=3m" .github/workflows/e2e.yaml

echo -e "\nJobs with E2E_WAIT_FOR_CREATE_INDEX_DURATION set to 5m:"
grep -n "E2E_WAIT_FOR_CREATE_INDEX_DURATION=5m" .github/workflows/e2e.yaml

Length of output: 788

E2E_TARGET_POD_NAME=${POD_NAME} \
E2E_TARGET_NAMESPACE=default \
e2e/skip
Expand Down
40 changes: 26 additions & 14 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ $(LIB_PATH)/libfaiss.a:
-DBUILD_STATIC_EXECS=ON \
-DBUILD_TESTING=OFF \
-DFAISS_ENABLE_PYTHON=OFF \
-DFAISS_ENABLE_GPU=OFF \
-DFAISS_ENABLE_GPU=OFF \
-DBLA_VENDOR=OpenBLAS \
-DCMAKE_C_FLAGS="$(LDFLAGS)" \
-DCMAKE_EXE_LINKER_FLAGS="$(FAISS_LDFLAGS)" \
Expand All @@ -679,19 +679,32 @@ $(LIB_PATH)/libfaiss.a:

.PHONY: usearch/install
## install usearch
usearch/install:
ifeq ($(OS),linux)
curl -sSL https://github.com/unum-cloud/usearch/releases/download/v$(USEARCH_VERSION)/usearch_$(OS)_$(GOARCH)_$(USEARCH_VERSION).deb -o usearch_$(OS)_$(USEARCH_VERSION).deb
dpkg -i usearch_$(OS)_$(USEARCH_VERSION).deb
rm usearch_$(OS)_$(USEARCH_VERSION).deb
ldconfig
else ifeq ($(OS),macos)
curl -sSL https://github.com/unum-cloud/usearch/releases/download/v$(USEARCH_VERSION)/usearch_macos_$(GOARCH)_$(USEARCH_VERSION).zip -o usearch_macos_$(OS)_$(USEARCH_VERSION).zip
unzip usearch_macos_$(OS)_$(USEARCH_VERSION).zip
sudo mv libusearch_c.dylib /usr/local/lib && sudo mv usearch.h /usr/local/include
rm -rf usearch_macos_$(OS)_$(USEARCH_VERSION).zip
usearch/install: $(USR_LOCAL)/include/usearch.h
$(USR_LOCAL)/include/usearch.h:
git clone --depth 1 --recursive --branch v$(USEARCH_VERSION) https://github.com/unum-cloud/usearch $(TEMP_DIR)/usearch-$(USEARCH_VERSION)
cd $(TEMP_DIR)/usearch-$(USEARCH_VERSION) && \
cmake -DCMAKE_BUILD_TYPE=Release \
-DBUILD_SHARED_LIBS=OFF \
-DBUILD_TESTING=OFF \
-DUSEARCH_BUILD_LIB_C=ON \
-DUSEARCH_USE_FP16LIB=ON \
-DUSEARCH_USE_OPENMP=ON \
-DUSEARCH_USE_SIMSIMD=ON \
-DUSEARCH_USE_JEMALLOC=ON \
-DCMAKE_C_FLAGS="$(CFLAGS)" \
-DCMAKE_CXX_FLAGS="$(CXXFLAGS)" \
-DCMAKE_INSTALL_PREFIX=$(USR_LOCAL) \
-DCMAKE_INSTALL_LIBDIR=$(LIB_PATH) \
-B $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build $(TEMP_DIR)/usearch-$(USEARCH_VERSION)
cmake --build $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build -j$(CORES)
cmake --install $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build --prefix=$(USR_LOCAL)
cd $(ROOTDIR)
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_c.a
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_static_c.a
Comment on lines +702 to +703
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Redundant copying of static library file

The static library libusearch_static_c.a is being copied to both $(LIB_PATH)/libusearch_c.a and $(LIB_PATH)/libusearch_static_c.a. Unless both filenames are required for compatibility reasons, this duplication may be unnecessary.

Consider removing one of the copy commands to eliminate redundancy:

 cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_c.a
-cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_static_c.a
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_c.a
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_static_c.a
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_static_c.a $(LIB_PATH)/libusearch_c.a

cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/build/libusearch_c.so $(LIB_PATH)/libusearch_c.so
cp $(TEMP_DIR)/usearch-$(USEARCH_VERSION)/c/usearch.h $(USR_LOCAL)/include/usearch.h
rm -rf $(TEMP_DIR)/usearch-$(USEARCH_VERSION)
Comment on lines +682 to +706
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Installation Verification Failed

The usearch/install target does not correctly install usearch.h and related components.

  • Missing usearch.h: The header file usearch.h is not found in /usr/local/include/.
  • Missing Include Directory: The directory /usr/local/include/ does not exist, preventing proper installation of header files.
  • Installation Steps Incomplete: The Makefile may be missing steps to create necessary directories or correctly place installation files.

Please review the usearch/install target in the Makefile to ensure that all required directories are created and that usearch.h along with other components are correctly installed.

🔗 Analysis chain

Improved usearch installation process

The usearch/install target has been updated to use a more robust installation process. This change improves the build and installation of the usearch library.

Key improvements:

  1. Uses git clone to fetch the source code, ensuring version consistency.
  2. Utilizes CMake for building, which is more flexible and maintainable.
  3. Enables several optimizations like FP16LIB, OpenMP, SimSIMD, and jemalloc.
  4. Properly installs both static and shared libraries.
  5. Copies the header file to the correct location.

These changes should result in a more optimized and better-integrated usearch library.

To ensure the installation process works as expected, you can run the following script:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify usearch installation

# Test: Check if usearch.h is installed
if [ -f "$(USR_LOCAL)/include/usearch.h" ]; then
    echo "usearch.h is installed correctly"
else
    echo "Error: usearch.h is not installed"
    exit 1
fi

# Test: Check if libusearch_c.a is installed
if [ -f "$(LIB_PATH)/libusearch_c.a" ]; then
    echo "libusearch_c.a is installed correctly"
else
    echo "Error: libusearch_c.a is not installed"
    exit 1
fi

# Test: Check if libusearch_c.so is installed
if [ -f "$(LIB_PATH)/libusearch_c.so" ]; then
    echo "libusearch_c.so is installed correctly"
else
    echo "Error: libusearch_c.so is not installed"
    exit 1
fi

echo "All usearch components are installed correctly"

Length of output: 200

Script:

#!/bin/bash
# Description: Verify usearch installation with LIB_PATH defined

# Define LIB_PATH
LIB_PATH="/usr/local/lib"

# Test: Check if usearch.h is installed
if [ -f "${USR_LOCAL}/include/usearch.h" ]; then
    echo "usearch.h is installed correctly"
else
    echo "Error: usearch.h is not installed"
    exit 1
fi

# Test: Check if libusearch_c.a is installed
if [ -f "${LIB_PATH}/libusearch_c.a" ]; then
    echo "libusearch_c.a is installed correctly"
else
    echo "Error: libusearch_c.a is not installed"
    exit 1
fi

# Test: Check if libusearch_c.so is installed
if [ -f "${LIB_PATH}/libusearch_c.so" ]; then
    echo "libusearch_c.so is installed correctly"
else
    echo "Error: libusearch_c.so is not installed"
    exit 1
fi

# Optional: Check if libfaiss.a is installed
if [ -f "${LIB_PATH}/libfaiss.a" ]; then
    echo "libfaiss.a is installed correctly"
else
    echo "Error: libfaiss.a is not installed"
    exit 1
fi

echo "All usearch components are installed correctly"

Length of output: 143

Script:

#!/bin/bash
# Description: Verify usearch installation with LIB_PATH and USR_LOCAL defined

# Define LIB_PATH and USR_LOCAL
LIB_PATH="/usr/local/lib"
USR_LOCAL="/usr/local"

# Test: Check if usearch.h is installed
if [ -f "${USR_LOCAL}/include/usearch.h" ]; then
    echo "usearch.h is installed correctly"
else
    echo "Error: usearch.h is not installed"
    exit 1
fi

# Test: Check if libusearch_c.a is installed
if [ -f "${LIB_PATH}/libusearch_c.a" ]; then
    echo "libusearch_c.a is installed correctly"
else
    echo "Error: libusearch_c.a is not installed"
    exit 1
fi

# Test: Check if libusearch_c.so is installed
if [ -f "${LIB_PATH}/libusearch_c.so" ]; then
    echo "libusearch_c.so is installed correctly"
else
    echo "Error: libusearch_c.so is not installed"
    exit 1
fi

# Optional: Check if libfaiss.a is installed
if [ -f "${LIB_PATH}/libfaiss.a" ]; then
    echo "libfaiss.a is installed correctly"
else
    echo "Error: libfaiss.a is not installed"
    exit 1
fi

echo "All usearch components are installed correctly"

Length of output: 176

Script:

#!/bin/bash
# Description: Search for usearch.h in the repository

# Define USR_LOCAL
USR_LOCAL="/usr/local"

# Search for usearch.h using fd
echo "Searching for usearch.h using fd..."
fd --extension h --name usearch.h /usr/local/include

# If not found, search the entire repository
if [ $? -ne 0 ]; then
    echo "usearch.h not found in /usr/local/include. Searching entire repository..."
    fd --extension h --name usearch.h
fi

# Alternatively, use find
echo "Searching for usearch.h using find..."
find /usr/local/include -type f -name usearch.h
find . -type f -name usearch.h

Length of output: 1093

Script:

#!/bin/bash
# Description: Search for usearch.h in the repository with corrected commands

# Define USR_LOCAL
USR_LOCAL="/usr/local"

# Check if /usr/local/include exists
if [ -d "${USR_LOCAL}/include" ]; then
    echo "Searching for usearch.h in ${USR_LOCAL}/include using fd..."
    fd --extension h usearch.h "${USR_LOCAL}/include"
else
    echo "Directory ${USR_LOCAL}/include does not exist. Skipping fd search in this directory."
fi

# Search for usearch.h using fd in the entire repository without --name flag
echo "Searching for usearch.h in the entire repository using fd..."
fd usearch.h -e h

# Alternatively, use find to search the entire repository
echo "Searching for usearch.h in the entire repository using find..."
find . -type f -name "usearch.h"

Length of output: 548

ldconfig
endif

.PHONY: cmake/install
## install CMAKE
Expand All @@ -710,7 +723,6 @@ cmake/install:
cd $(ROOTDIR)
rm -rf $(TEMP_DIR)/CMAKE-$(CMAKE_VERSION)
ldconfig
# -DCMAKE_USE_OPENSSL=OFF

.PHONY: lint
## run lints
Expand Down
2 changes: 1 addition & 1 deletion apis/grpc/v1/agent/sidecar/sidecar_vtproto.pb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const _ = grpc.SupportPackageIsVersion7
// SidecarClient is the client API for Sidecar service.
//
// For semantics around ctx use and closing/ending streaming RPCs, please refer to https://pkg.go.dev/google.golang.org/grpc/?tab=doc#ClientConn.NewStream.
type SidecarClient interface{}
type SidecarClient any

type sidecarClient struct {
cc grpc.ClientConnInterface
Expand Down
Loading
Loading