-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gateway): delete unused file #2644
refactor(gateway): delete unused file #2644
Conversation
📝 WalkthroughWalkthroughThe pull request involves the complete removal of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
User->>System: Request to access location functionality
System-->>User: Response with location data
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files not reviewed due to no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for your contribution. |
@all-contributors please add @highpon for test |
I've put up a pull request to add @highpon! 🎉 |
@kpango So it looks like I don't need to create a new commit! |
Got it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
- Coverage 24.36% 24.35% -0.02%
==========================================
Files 536 536
Lines 46459 46459
==========================================
- Hits 11319 11313 -6
- Misses 34371 34378 +7
+ Partials 769 768 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!!
LGTM!
Co-authored-by: s-shiraki <[email protected]>
Description
The file
pkg/gateway/internal/location/location_test.go
exists but is not used.This PR removes
pkg/gateway/internal/location/location_test.go
, which is not used.Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
location_test.go
file, which contained licensing information and package declarations but no functional code or tests.