Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gateway): delete unused file #2644

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

highpon
Copy link
Contributor

@highpon highpon commented Sep 26, 2024

Description

The file pkg/gateway/internal/location/location_test.go exists but is not used.
This PR removes pkg/gateway/internal/location/location_test.go, which is not used.

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.1
  • Rust Version: v1.81.0
  • Docker Version: v27.2.1
  • Kubernetes Version: v1.31.0
  • Helm Version: v3.16.0
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Chores
    • Removed the location_test.go file, which contained licensing information and package declarations but no functional code or tests.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

📝 Walkthrough

Walkthrough

The pull request involves the complete removal of the location_test.go file from the pkg/gateway/internal/location directory. This file previously contained licensing information and the package declaration for the location package. The change indicates that the file did not include any functional code or tests.

Changes

File Path Change Summary
pkg/gateway/internal/location/location_test.go Removed the file entirely, which contained licensing info and package declaration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    User->>System: Request to access location functionality
    System-->>User: Response with location data
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 686c16a and 7158503.

📒 Files selected for processing (1)
  • pkg/gateway/internal/location/location_test.go (0 hunks)
💤 Files not reviewed due to no reviewable changes (1)
  • pkg/gateway/internal/location/location_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kpango
Copy link
Collaborator

kpango commented Sep 26, 2024

Thank you for your contribution.
It would be better to remove pkg/gateway/internal directory as well, which is never used for now.

@kpango
Copy link
Collaborator

kpango commented Sep 26, 2024

@all-contributors please add @highpon for test

Copy link
Contributor

@kpango

I've put up a pull request to add @highpon! 🎉

@highpon
Copy link
Contributor Author

highpon commented Sep 27, 2024

@kpango
Thanks for the review!
I checked and the pkg/gateway/internal directory was also gone in the current commit!
https://github.com/highpon/vald/tree/refactoring/gateway/delete-unused-file/pkg/gateway

So it looks like I don't need to create a new commit!

@kpango
Copy link
Collaborator

kpango commented Sep 27, 2024

Got it.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.35%. Comparing base (10cfd82) to head (7158503).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   24.36%   24.35%   -0.02%     
==========================================
  Files         536      536              
  Lines       46459    46459              
==========================================
- Hits        11319    11313       -6     
- Misses      34371    34378       +7     
+ Partials      769      768       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpango kpango requested review from vankichi and hlts2 and removed request for vankichi September 27, 2024 01:20
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!!
LGTM!

@kpango kpango merged commit 0039af1 into vdaas:main Sep 27, 2024
110 of 114 checks passed
vdaas-ci pushed a commit that referenced this pull request Sep 27, 2024
kpango pushed a commit that referenced this pull request Sep 27, 2024
@highpon highpon deleted the refactoring/gateway/delete-unused-file branch September 27, 2024 03:14
@kpango kpango mentioned this pull request Oct 11, 2024
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants