Refactor test checkFunc condition #2599

vankichi · 2024-09-09T03:25:55Z

Description

SSIA

Related Issue

Versions

Vald Version: v1.7.13
Go Version: v1.23.0
Rust Version: v1.80.0
Docker Version: v27.1.1
Kubernetes Version: v1.30.3
Helm Version: v3.15.3
NGT Version: v2.2.4
Faiss Version: v1.8.0

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

Bug Fixes
- Adjusted the conditional logic in test functions to improve accuracy in vector dimension checks, allowing for more granular error reporting and potentially enhancing test reliability.

Signed-off-by: vankichi <[email protected]>

coderabbitai · 2024-09-09T03:26:03Z

Walkthrough

The pull request modifies the conditional checks in the test functions TestFloat32VectorGenerator and TestUint8VectorGenerator. The previous implementation used a direct equality comparison to validate the lengths of generated vectors against expected dimensions. This has been changed to a logical OR operator and subsequently to separate checks for each dimension, allowing for more granular error reporting. These alterations affect the control flow and may lead to different outcomes in the tests.

Changes

Files	Change Summary
internal/test/data/vector/gen_test.go	Modified conditional checks in `TestFloat32VectorGenerator` and `TestUint8VectorGenerator` to use logical expressions for dimension validation, allowing for individual error reporting.

Tip

New features

Walkthrough comment now includes:

Possibly related PRs: A list of potentially related PRs to help you recall past context.
Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

Please share any feedback in the discussion post on our Discord.
Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vdaas-ci · 2024-09-09T03:26:08Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

coderabbitai

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b17cc73 and a8489bc.

Files selected for processing (1)

internal/test/data/vector/gen_test.go (2 hunks)

internal/test/data/vector/gen_test.go

codecov · 2024-09-09T03:35:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.56%. Comparing base (4560a2b) to head (fbeb95f).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
+ Coverage   24.55%   24.56%   +0.01%     
==========================================
  Files         530      530              
  Lines       45522    45522              
==========================================
+ Hits        11176    11181       +5     
+ Misses      33596    33592       -4     
+ Partials      750      749       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: vankichi <[email protected]>

cloudflare-workers-and-pages · 2024-09-09T03:36:12Z

Deploying vald with Cloudflare Pages

Latest commit:	`fbeb95f`
Status:	✅ Deploy successful!
Preview URL:	https://a64069ce.vald.pages.dev
Branch Preview URL:	https://bugfix-internal-fix-gen-test.vald.pages.dev

View logs

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a8489bc and 4d60fae.

Files selected for processing (1)

internal/test/data/vector/gen_test.go (1 hunks)

internal/test/data/vector/gen_test.go

Signed-off-by: vankichi <[email protected]>

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d60fae and fbeb95f.

Files selected for processing (1)

internal/test/data/vector/gen_test.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

internal/test/data/vector/gen_test.go

hlts2

LGTM!

* 🐛 ✅ Fix checkFun condition Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]>

* 🐛 ✅ Fix checkFun condition * ♻️ Fix by feedback * ♻️ Fix by feedback --------- Signed-off-by: vankichi <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]>

* 🐛 ✅ Fix checkFun condition Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]>

🐛 ✅ Fix checkFun condition

a8489bc

Signed-off-by: vankichi <[email protected]>

github-actions bot added area/internal size/S type/bug Something isn't working priority/medium labels Sep 9, 2024

coderabbitai bot requested changes Sep 9, 2024

View reviewed changes

internal/test/data/vector/gen_test.go Outdated Show resolved Hide resolved

internal/test/data/vector/gen_test.go Outdated Show resolved Hide resolved

♻️ Fix by feedback

4d60fae

Signed-off-by: vankichi <[email protected]>

coderabbitai bot requested changes Sep 9, 2024

View reviewed changes

internal/test/data/vector/gen_test.go Outdated Show resolved Hide resolved

♻️ Fix by feedback

fbeb95f

Signed-off-by: vankichi <[email protected]>

coderabbitai bot reviewed Sep 9, 2024

View reviewed changes

coderabbitai bot approved these changes Sep 9, 2024

View reviewed changes

vankichi requested review from a team, kmrmt and hlts2 and removed request for a team September 10, 2024 07:03

vankichi changed the title ~~Fix test checkFunc condition~~ Refactor test checkFunc condition Sep 10, 2024

vankichi added the actions/backport/release/v1.7 label Sep 10, 2024

kmrmt approved these changes Sep 10, 2024

View reviewed changes

hlts2 approved these changes Sep 10, 2024

View reviewed changes

hlts2 merged commit f418cc9 into main Sep 10, 2024
76 of 77 checks passed

hlts2 deleted the bugfix/internal/fix-gen-test-checkfc branch September 10, 2024 07:42

coderabbitai bot mentioned this pull request Sep 12, 2024

implement richer error model #2589

Merged

2 tasks

github-actions bot mentioned this pull request Oct 1, 2024

Monthly review time metrics report: 2024-09-01..2024-09-30 #2662

Closed

coderabbitai bot mentioned this pull request Oct 8, 2024

Fix gRPC error msg handling for lb-gateway handler #2663

Merged

2 tasks

kpango mentioned this pull request Oct 11, 2024

[patch] Release v1.7.14 #2699

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor test checkFunc condition #2599

Refactor test checkFunc condition #2599

vankichi commented Sep 9, 2024 •

edited

Loading

coderabbitai bot commented Sep 9, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vdaas-ci commented Sep 9, 2024

coderabbitai bot left a comment

codecov bot commented Sep 9, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 9, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

hlts2 left a comment

Refactor test checkFunc condition #2599

Refactor test checkFunc condition #2599

Conversation

vankichi commented Sep 9, 2024 • edited Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

coderabbitai bot commented Sep 9, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vdaas-ci commented Sep 9, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Sep 9, 2024 • edited Loading

Deploying vald with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Sep 9, 2024 •

edited

Loading

coderabbitai bot commented Sep 9, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Sep 9, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 9, 2024 •

edited

Loading