Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix NGT flush logic #2598
Bugfix NGT flush logic #2598
Changes from 10 commits
4a90356
833ccf7
50861c7
f8b76c6
d27ba65
3433f28
42d0553
0500393
9d1f550
9588ef3
c561c89
b3151dc
d4c79e2
3506054
b768b5d
8738f12
c293365
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 69 in pkg/agent/core/ngt/handler/grpc/index.go
Codecov / codecov/patch
pkg/agent/core/ngt/handler/grpc/index.go#L67-L69
Check warning on line 157 in pkg/agent/core/ngt/handler/grpc/index.go
Codecov / codecov/patch
pkg/agent/core/ngt/handler/grpc/index.go#L155-L157
Check warning on line 911 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L911
Check warning on line 1252 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L1252
Check warning on line 1306 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L1305-L1306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Added logic to check if a vqueue reference could be nil if a flush is running.
Check warning on line 1950 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L1950
Check warning on line 1957 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L1957
Check warning on line 1964 in pkg/agent/core/ngt/service/ngt.go
Codecov / codecov/patch
pkg/agent/core/ngt/service/ngt.go#L1964