Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix NGT flush logic #2598

Merged
merged 17 commits into from
Sep 11, 2024

fix: disable commentout

9588ef3
Select commit
Loading
Failed to load commit list.
Merged

Bugfix NGT flush logic #2598

fix: disable commentout
9588ef3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 9, 2024 in 0s

24.55% (+0.00%) compared to 4560a2b

View this Pull Request on Codecov

24.55% (+0.00%) compared to 4560a2b

Details

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 24.55%. Comparing base (4560a2b) to head (9588ef3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/core/ngt/service/ngt.go 53.33% 7 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/index.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   24.55%   24.55%           
=======================================
  Files         530      530           
  Lines       45522    45531    +9     
=======================================
+ Hits        11176    11182    +6     
- Misses      33596    33600    +4     
+ Partials      750      749    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.