Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2584 to release/v1.7 for Implement ngt property get API #2588

Merged

fix conflict

bf54494
Select commit
Loading
Failed to load commit list.
Merged

Backport PR #2584 to release/v1.7 for Implement ngt property get API #2588

fix conflict
bf54494
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 19.37984% with 208 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.7@7fe3c9c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/gateway/lb/handler/grpc/handler.go 0.00% 92 Missing ⚠️
internal/core/algorithm/ngt/ngt.go 43.95% 51 Missing ⚠️
pkg/agent/core/ngt/service/ngt.go 0.00% 40 Missing ⚠️
internal/client/v1/client/vald/vald.go 0.00% 21 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/index.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.7    #2588   +/-   ##
===============================================
  Coverage                ?   24.55%           
===============================================
  Files                   ?      530           
  Lines                   ?    45505           
  Branches                ?        0           
===============================================
  Hits                    ?    11172           
  Misses                  ?    33586           
  Partials                ?      747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.