Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] [BUGFIX] v1.7.12 Last Agent's index correction process not enough #2573

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Aug 7, 2024

Description

Related Issue

Versions

  • Vald Version: v1.7.12
  • Go Version: v1.22.5
  • Rust Version: v1.80.0
  • Docker Version: v27.1.1
  • Kubernetes Version: v1.30.3
  • Helm Version: v3.15.3
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Important

Review skipped

Ignore keyword(s) in the title.

Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kpango kpango changed the base branch from feature/egress-gateway/add-egress-query to main August 7, 2024 00:04
@kpango kpango marked this pull request as ready for review August 7, 2024 00:18
@kpango kpango force-pushed the bugfix/v1.7.12/last-agent-index-correction-not-enought-bug branch from 3e25f58 to 722a6ab Compare August 7, 2024 00:19
Copy link

cloudflare-workers-and-pages bot commented Aug 7, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20fdca8
Status: ✅  Deploy successful!
Preview URL: https://e4a2c7a1.vald.pages.dev
Branch Preview URL: https://bugfix-v1-7-12-last-agent-in.vald.pages.dev

View logs

@kpango kpango changed the base branch from main to dummy/v1.7.12 August 7, 2024 00:20
@kpango kpango changed the title [DO NOT MERGE] [BUGFIX] v1.7.12 Last Agent's index correction process… … not enought [DO NOT MERGE] [BUGFIX] v1.7.12 Last Agent's index correction process not enough Aug 7, 2024
@kpango kpango removed the ci/approved label Aug 7, 2024
@kpango kpango force-pushed the bugfix/v1.7.12/last-agent-index-correction-not-enought-bug branch from 722a6ab to 2b4402c Compare August 7, 2024 00:23
@kpango kpango force-pushed the bugfix/v1.7.12/last-agent-index-correction-not-enought-bug branch from 2b4402c to 20fdca8 Compare August 7, 2024 00:31
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (dummy/v1.7.12@c391300). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/index/job/correction/service/corrector.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             dummy/v1.7.12    #2573   +/-   ##
================================================
  Coverage                 ?   18.70%           
================================================
  Files                    ?      549           
  Lines                    ?    73857           
  Branches                 ?        0           
================================================
  Hits                     ?    13814           
  Misses                   ?    59301           
  Partials                 ?      742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpango kpango closed this Oct 25, 2024
@kpango kpango deleted the bugfix/v1.7.12/last-agent-index-correction-not-enought-bug branch October 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant