Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync release/v1.7 to main #2495

Merged
merged 63 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
504dbe3
fix: git add chart directory for release (#2356)
hlts2 Feb 15, 2024
50fc4cc
:bookmark: :robot: Release v1.7.11 (#2360) (#2361)
vdaas-ci Feb 15, 2024
f72fe07
Change docker scan timeout longer (#2363)
ykadowak Feb 15, 2024
915a670
refactor code using golangci-lint (#2362)
kpango Feb 15, 2024
2de5f0e
Create SECURITY.md (#2367)
kpango Feb 16, 2024
b906fd2
add commit hash build image (#2359)
kpango Feb 16, 2024
699ba22
Make agent export index metrics to Pod k8s resource (#2319)
ykadowak Feb 16, 2024
3f25b31
update docker build target platform selection rules (#2370)
kpango Feb 16, 2024
47e1312
improve Backport Pull Request Title & Description Quality (#2373)
kpango Feb 16, 2024
e6c43b3
Update workflow to release readreplica chart (#2383)
ykadowak Feb 19, 2024
f080436
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (…
vankichi Feb 20, 2024
284186b
Delete unnecessary code for mirror (#2366)
hlts2 Feb 20, 2024
d482c0f
change JP logo to EN logo (#2369)
taisuou Feb 20, 2024
18f22d5
Add rotate-all option to rotator (#2305)
ykadowak Feb 21, 2024
df33f92
Resolve kvs already closed before last saving (#2390)
kpango Feb 21, 2024
cc7ab04
create continous benchmark doc (#2352)
vankichi Feb 21, 2024
db555fe
fix: build error of internal kvs test (#2396)
hlts2 Feb 21, 2024
19218f8
:robot: Update license headers / Format Go codes and YAML files (#2397)
vdaas-ci Feb 21, 2024
99a1155
fix: disable protobuf dispatch for client (#2401)
hlts2 Feb 21, 2024
f30f6bd
update deps (#2404)
kpango Feb 21, 2024
668a5c1
:bookmark: :robot: Release v1.7.12 (#2408) (#2409)
vdaas-ci Feb 22, 2024
79185fe
Add tests for index information export (#2412)
ykadowak Feb 26, 2024
8ea1226
:pencil: Fix typo of file name (#2413)
vankichi Feb 26, 2024
15a751c
Fix agent-faiss build failed (#2418)
vankichi Feb 26, 2024
e1b09fe
Fix the logic to determine docker image (#2410)
hlts2 Feb 27, 2024
1d4efd8
Update build rule for nightly image (#2421)
hlts2 Feb 27, 2024
e97fb0c
Add `index-operator` template implementation (#2375)
ykadowak Feb 27, 2024
8a77a5d
Fix output settings to determine-docker-image-tag action and release …
hlts2 Feb 27, 2024
894df4d
fix: typo of execution rule (#2426)
hlts2 Feb 28, 2024
aba46a8
Add flush API for deleting all vectors (#2273)
aknishid Mar 4, 2024
4efff24
docs: add aknishid as a contributor for code, and maintenance (#2431)
allcontributors[bot] Mar 4, 2024
b730f04
update deps & add validation for Flush API when agent is Read Only (#…
kpango Mar 4, 2024
4424c4b
Update README.md (grammer) (#2440)
hrichiksite Mar 8, 2024
5b0996c
docs: add hrichiksite as a contributor for doc (#2441)
allcontributors[bot] Mar 8, 2024
6182000
Added snapshot timestamp annotations to read replica agent (#2428)
ykadowak Mar 8, 2024
64e4514
fix: bugfix version update for docker build (#2445)
hlts2 Mar 8, 2024
fa1c39b
Fix index job logic to pass DNS A record (#2438)
hlts2 Mar 12, 2024
663d001
Fix operator-sdk version (#2447)
hlts2 Mar 12, 2024
52fc580
add file name lint (#2417)
kpango Mar 12, 2024
6a3bd2e
fix: add extra option for ci-container build (#2451)
hlts2 Mar 15, 2024
56cddd0
Add base of benchmark operator dashboard (#2430)
vankichi Mar 15, 2024
ada41cb
Implement index operator logic for read replica rotation (#2444)
ykadowak Mar 15, 2024
f5186e9
add inner product distance type for ngt (#2454)
kpango Mar 15, 2024
0427b62
Fix e2e for read replica and add e2e for index operator (#2455)
ykadowak Mar 18, 2024
f8280b2
Add unit tests for index operator (#2460)
ykadowak Mar 19, 2024
f03bbb2
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE…
vdaas-ci Mar 19, 2024
57e352e
Bugfix recreate benchmark job when operator reboot (#2463)
vankichi Mar 22, 2024
8bf4b82
Refactor k8s types (#2462)
ykadowak Mar 22, 2024
179ce6f
add extra flags for NGT build phase (#2467)
kmrmt Mar 25, 2024
5ad9e27
Fix workflow trigger for backport pr creation (#2471)
hlts2 Apr 1, 2024
df77a77
Automatically add backport main label for release-pr (#2473)
hlts2 Apr 2, 2024
63b53ea
update deps (#2468)
kpango Apr 4, 2024
87b4d9a
Update README.md (#2479)
kpango Apr 22, 2024
9e091b1
Implement client metrics interceptor for continuous benchmark job (#2…
vankichi Apr 22, 2024
f062590
implement ngt-rs and its unit test and add GitHub Actions workflows (…
kmrmt Apr 22, 2024
815d78f
:chart_with_upwards_trend: Add client metrics panels for continuous b…
vankichi Apr 23, 2024
548d946
Add rust versions (#2482)
kmrmt Apr 25, 2024
696bfd6
Update continuous benchmark docs (#2485)
vankichi Apr 25, 2024
9c12b90
update NGT version (#2484)
kmrmt Apr 26, 2024
fe962e4
fix sed line (#2488)
kmrmt Apr 30, 2024
41c002c
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE…
vdaas-ci Apr 30, 2024
6d4b505
Add efficient search logic for large top-k users (#2491)
kpango May 8, 2024
d511b4c
Merge branch 'main' into sync-to-release-1-7-branch
hlts2 May 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .gitfiles
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
.github/workflows/coverage.yml
.github/workflows/detect-internal-config-changes.yml
.github/workflows/dockers-agent-faiss-image.yml
.github/workflows/dockers-agent-image.yml
.github/workflows/dockers-agent-ngt-image.yml
.github/workflows/dockers-agent-sidecar-image.yml
.github/workflows/dockers-benchmark-job-image.yml
Expand Down Expand Up @@ -167,8 +168,10 @@ apis/grpc/v1/mirror/mirror.pb.go
apis/grpc/v1/mirror/mirror_vtproto.pb.go
apis/grpc/v1/payload/interface.go
apis/grpc/v1/payload/payload.pb.go
apis/grpc/v1/payload/payload.pb.json.go
apis/grpc/v1/payload/payload_vtproto.pb.go
apis/grpc/v1/rpc/errdetails/error_details.pb.go
apis/grpc/v1/rpc/errdetails/error_details.pb.json.go
apis/grpc/v1/rpc/errdetails/error_details_vtproto.pb.go
apis/grpc/v1/vald/filter.pb.go
apis/grpc/v1/vald/filter_vtproto.pb.go
Expand Down Expand Up @@ -243,6 +246,7 @@ assets/docs/overview/search_flow.svg
assets/docs/overview/update_flow.svg
assets/docs/overview/upsert_flow.svg
assets/docs/overview/vald_basic_architecture.svg
assets/docs/performance/benchmark-grafana.png
assets/docs/troubleshooting/provisioning_flow_chart.drawio
assets/docs/troubleshooting/provisioning_flow_chart.svg
assets/docs/tutorial/getstarted.svg
Expand Down Expand Up @@ -505,6 +509,8 @@ design/Vald Architecture Assets.drawio
design/Vald Architecture Dataflow.drawio
design/Vald Architecture Overview.drawio
design/vald_architecture_overview.png
dockers/agent/core/agent/Dockerfile
dockers/agent/core/agent/README.md
dockers/agent/core/faiss/Dockerfile
dockers/agent/core/ngt/Dockerfile
dockers/agent/core/ngt/README.md
Expand Down Expand Up @@ -1121,6 +1127,7 @@ internal/net/grpc/handler.go
internal/net/grpc/health/health.go
internal/net/grpc/health/health_test.go
internal/net/grpc/interceptor.go
internal/net/grpc/interceptor/client/metric/metric.go
internal/net/grpc/interceptor/client/trace/trace.go
internal/net/grpc/interceptor/server/logging/accesslog.go
internal/net/grpc/interceptor/server/logging/accesslog_test.go
Expand Down Expand Up @@ -1814,6 +1821,11 @@ rust/Cargo.lock
rust/Cargo.toml
rust/bin/agent/Cargo.toml
rust/bin/agent/src/main.rs
rust/libs/ngt-rs/Cargo.toml
rust/libs/ngt-rs/build.rs
rust/libs/ngt-rs/src/input.cpp
rust/libs/ngt-rs/src/input.h
rust/libs/ngt-rs/src/lib.rs
rust/libs/ngt/Cargo.toml
rust/libs/ngt/src/lib.rs
rust/libs/proto/Cargo.toml
Expand All @@ -1836,6 +1848,7 @@ rust/libs/proto/src/sidecar.v1.rs
rust/libs/proto/src/sidecar.v1.tonic.rs
rust/libs/proto/src/vald.v1.rs
rust/libs/proto/src/vald.v1.tonic.rs
rust/rust-toolchain.toml
tests/chaos/chart/.helmignore
tests/chaos/chart/Chart.yaml
tests/chaos/chart/README.md
Expand Down Expand Up @@ -1881,6 +1894,7 @@ versions/OTEL_OPERATOR_VERSION
versions/PROMETHEUS_STACK_VERSION
versions/PROTOBUF_VERSION
versions/REVIEWDOG_VERSION
versions/RUST_VERSION
versions/TELEPRESENCE_VERSION
versions/VALDCLI_VERSION
versions/VALD_VERSION
Expand Down
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ assignees: ""

<!--- Please change the versions below along with your environment -->

- Go Version: 1.22.2
- Go Version: 1.22.3
- Rust Version: 1.77.2
- Docker Version: 20.10.8
- Kubernetes Version: v1.29.3
- NGT Version: 2.2
- Kubernetes Version: v1.30.0
- NGT Version: 2.2.1
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/security_issue_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ assignees: ""

<!--- Please change the versions below along with your environment -->

- Go Version: 1.22.2
- Go Version: 1.22.3
- Rust Version: 1.77.2
- Docker Version: 20.10.8
- Kubernetes Version: v1.29.3
- NGT Version: 2.2
- Kubernetes Version: v1.30.0
- NGT Version: 2.2.1
7 changes: 4 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@

<!--- Please change the versions below along with your environment -->

- Go Version: 1.22.2
- Go Version: 1.22.3
- Rust Version: 1.77.2
- Docker Version: 20.10.8
- Kubernetes Version: v1.29.3
- NGT Version: 2.2
- Kubernetes Version: v1.30.0
- NGT Version: 2.2.1

### Checklist

Expand Down
74 changes: 74 additions & 0 deletions .github/workflows/dockers-agent-image.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
#
# Copyright (C) 2019-2024 vdaas.org vald team <[email protected]>
#
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
name: "Build docker image: agent"
on:
push:
branches:
- "main"
- "release/v*.*"
- "!release/v*.*.*"
tags:
- "*.*.*"
- "v*.*.*"
- "*.*.*-*"
- "v*.*.*-*"
paths:
- ".github/actions/docker-build/action.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-agent-image.yml"
- "rust/Cargo.lock"
- "rust/Cargo.toml"
- "rust/bin/agent/**"
- "rust/libs/ngt/**"
- "rust/libs/ngt-rs/**"
- "rust/libs/proto/**"
- "dockers/agent/core/ngt-rust/Dockerfile"
- "versions/RUST_VERSION"
- "versions/NGT_VERSION"
pull_request:
paths:
- ".github/actions/docker-build/action.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-agent-image.yml"
- "rust/Cargo.lock"
- "rust/Cargo.toml"
- "rust/bin/agent/**"
- "rust/libs/ngt/**"
- "rust/libs/ngt-rs/**"
- "rust/libs/proto/**"
- "dockers/agent/core/agent/Dockerfile"
- "versions/RUST_VERSION"
- "versions/NGT_VERSION"
pull_request_target:
paths:
- ".github/actions/docker-build/action.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-agent-image.yml"
- "rust/Cargo.lock"
- "rust/Cargo.toml"
- "rust/bin/agent/**"
- "rust/libs/ngt/**"
- "rust/libs/ngt-rs/**"
- "rust/libs/proto/**"
- "dockers/agent/core/agent/Dockerfile"
- "versions/RUST_VERSION"
- "versions/NGT_VERSION"
jobs:
build:
uses: ./.github/workflows/_docker-image.yaml
with:
target: agent
secrets: inherit
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ on:
- "versions/GO_VERSION"
- "versions/NGT_VERSION"
- "versions/KUBECTL_VERSION"
- "versions/RUST_VERSION"
jobs:
dump-contexts-to-log:
runs-on: ubuntu-latest
Expand Down
22 changes: 17 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ GHCRORG = ghcr.io/$(ORG)/$(NAME)
AGENT_NGT_IMAGE = $(NAME)-agent-ngt
AGENT_FAISS_IMAGE = $(NAME)-agent-faiss
AGENT_SIDECAR_IMAGE = $(NAME)-agent-sidecar
AGENT_IMAGE = $(NAME)-agent
CI_CONTAINER_IMAGE = $(NAME)-ci-container
DEV_CONTAINER_IMAGE = $(NAME)-dev-container
DISCOVERER_IMAGE = $(NAME)-discoverer-k8s
Expand Down Expand Up @@ -58,9 +59,12 @@ GO_CLEAN_DEPS := true
GOTEST_TIMEOUT = 30m
CGO_ENABLED = 1

RUST_HOME = /usr/local/lib/rust
RUSTUP_HOME = $(RUST_HOME)/rustup
CARGO_HOME = $(RUST_HOME)/cargo
RUST_HOME ?= /usr/local/lib/rust
RUSTUP_HOME ?= $(RUST_HOME)/rustup
CARGO_HOME ?= $(RUST_HOME)/cargo
RUST_VERSION := $(eval RUST_VERSION := $(shell cat versions/RUST_VERSION))$(RUST_VERSION)

NPM_GLOBAL_PREFIX := $(eval NPM_GLOBAL_PREFIX := $(shell npm prefix --location=global))$(NPM_GLOBAL_PREFIX)

NPM_GLOBAL_PREFIX := $(eval NPM_GLOBAL_PREFIX := $(shell npm prefix --location=global))$(NPM_GLOBAL_PREFIX)

Expand Down Expand Up @@ -138,14 +142,17 @@ ifeq ($(GOARCH),amd64)
CFLAGS ?= -mno-avx512f -mno-avx512dq -mno-avx512cd -mno-avx512bw -mno-avx512vl
CXXFLAGS ?= $(CFLAGS)
EXTLDFLAGS ?= -m64
NGT_EXTRA_FLAGS ?=
else ifeq ($(GOARCH),arm64)
CFLAGS ?=
CXXFLAGS ?= $(CFLAGS)
EXTLDFLAGS ?= -march=armv8-a
NGT_EXTRA_FLAGS ?=
else
CFLAGS ?=
CXXFLAGS ?= $(CFLAGS)
EXTLDFLAGS ?=
NGT_EXTRA_FLAGS ?=
endif

BENCH_DATASET_MD5S := $(eval BENCH_DATASET_MD5S := $(shell find $(BENCH_DATASET_MD5_DIR) -type f -regex ".*\.md5"))$(BENCH_DATASET_MD5S)
Expand Down Expand Up @@ -535,6 +542,11 @@ version/vald:
version/go:
@echo $(GO_VERSION)

.PHONY: version/rust
## print rust version
version/rust:
@echo $(RUST_VERSION)

.PHONY: version/ngt
## print NGT version
version/ngt:
Expand Down Expand Up @@ -571,7 +583,7 @@ ngt/install: /usr/local/include/NGT/Capi.h
/usr/local/include/NGT/Capi.h:
git clone --depth 1 --branch v$(NGT_VERSION) https://github.com/yahoojapan/NGT $(TEMP_DIR)/NGT-$(NGT_VERSION)
cd $(TEMP_DIR)/NGT-$(NGT_VERSION) && \
cmake -DCMAKE_C_FLAGS="$(CFLAGS)" -DCMAKE_CXX_FLAGS="$(CXXFLAGS)" .
cmake -DCMAKE_C_FLAGS="$(CFLAGS)" -DCMAKE_CXX_FLAGS="$(CXXFLAGS)" "$(NGT_EXTRA_FLAGS)" .
make -j -C $(TEMP_DIR)/NGT-$(NGT_VERSION)
make install -C $(TEMP_DIR)/NGT-$(NGT_VERSION)
cd $(ROOTDIR)
Expand All @@ -582,7 +594,7 @@ ngt/install: /usr/local/include/NGT/Capi.h
## install Faiss
faiss/install: /usr/local/lib/libfaiss.so
/usr/local/lib/libfaiss.so:
curl -LO https://github.com/facebookresearch/faiss/archive/v$(FAISS_VERSION).tar.gz
curl -fsSLO https://github.com/facebookresearch/faiss/archive/v$(FAISS_VERSION).tar.gz
tar zxf v$(FAISS_VERSION).tar.gz -C $(TEMP_DIR)/
cd $(TEMP_DIR)/faiss-$(FAISS_VERSION) && \
cmake -DFAISS_ENABLE_GPU=OFF -DFAISS_ENABLE_PYTHON=OFF -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -B build . && \
Expand Down
6 changes: 6 additions & 0 deletions Makefile.d/build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ cmd/tools/benchmark/operator/operator:
$(eval CGO_ENABLED = 0)
$(call go-build,tools/benchmark/operator,,-static,,,$@)

rust/target/release/agent:
pushd rust && cargo build -p agent --release && popd

rust/target/debug/agent:
pushd rust && cargo build -p agent && popd

.PHONY: binary/build/zip
## build all binaries and zip them
binary/build/zip: \
Expand Down
4 changes: 2 additions & 2 deletions Makefile.d/client.mk
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ valdcli/install: $(BINDIR)/valdcli
ifeq ($(UNAME),Darwin)
$(BINDIR)/valdcli:
mkdir -p $(BINDIR)
curl -LO https://github.com/rinx/vald-client-clj/releases/download/$(VALDCLI_VERSION)/valdcli-macos.zip
curl -fsSLO https://github.com/rinx/vald-client-clj/releases/download/$(VALDCLI_VERSION)/valdcli-macos.zip
unzip valdcli-macos.zip
rm -f valdcli-macos.zip
mv valdcli $(BINDIR)/valdcli
else
$(BINDIR)/valdcli:
mkdir -p $(BINDIR)
curl -LO https://github.com/rinx/vald-client-clj/releases/download/$(VALDCLI_VERSION)/valdcli-linux-static.zip
curl -fsSLO https://github.com/rinx/vald-client-clj/releases/download/$(VALDCLI_VERSION)/valdcli-linux-static.zip
unzip valdcli-linux-static.zip
rm -f valdcli-linux-static.zip
mv valdcli $(BINDIR)/valdcli
Expand Down
Loading
Loading