Backport PR #2491 to release/v1.7 for Add efficient search logic for large top-k users #2494

vdaas-ci · 2024-05-08T06:56:54Z

Description

Related Issue

Versions

Go Version: 1.22.2
Rust Version: 1.77.2
Docker Version: 20.10.8
Kubernetes Version: v1.29.3
NGT Version: 2.2.1

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

New Features
- Introduced a new Dockerfile and README for the core agent.
- Updated Kubernetes version across various GitHub templates to v1.30.0.
- Enhanced download commands with -fsS and -fsSL options across multiple Makefiles for improved security and reliability.
- Added new documentation images and updated installation commands in tutorials for Helm using secure curl options.
Bug Fixes
- Fixed protocol issues in URLs for downloading tools like golangci-lint, reviewdog, kubectl, and buf.
Documentation
- Updated Go version in example client module from 1.22.2 to 1.22.3.
- Enhanced existing documentation to reflect updated download commands and Kubernetes version changes.
Refactor
- Modified internal gRPC configuration to conditionally append health check durations, enhancing efficiency.

* add efficient search logic for large top-k users Signed-off-by: kpango <[email protected]> * fix bug Signed-off-by: kpango <[email protected]> --------- Signed-off-by: kpango <[email protected]>

cloudflare-workers-and-pages · 2024-05-08T06:56:55Z

Deploying vald with Cloudflare Pages

Latest commit:	`b522fd6`
Status:	✅ Deploy successful!
Preview URL:	https://34150f96.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-featur-p99z.vald.pages.dev

View logs

coderabbitai · 2024-05-08T06:58:05Z

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

19 files out of 76 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vdaas-ci · 2024-05-08T07:07:52Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2024-05-08T07:08:05Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions · 2024-05-08T07:16:46Z

internal/net/grpc/client.go

-			C: make(chan time.Time),
-		}
+		defer close(ech)
+		defer func() {


🚫 [golangci] _{reported by reviewdog 🐶}
Function StartConnectionMonitor$1$1 should pass the context parameter (contextcheck)

github-actions · 2024-05-08T07:16:47Z

pkg/gateway/lb/handler/grpc/search_benchmark_test.go

@@ -86,7 +86,7 @@ func newRandomResponse() (res *payload.Search_Response) {
 	return res
 }

-func benchmark(b *testing.B, results []*payload.Search_Response, anew func(n, r int) Aggregator) {
+func benchmark(b *testing.B, results []*payload.Search_Response, anew func(n, f, r int) Aggregator) {


🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from b.Helper() (thelper)

Add efficient search logic for large top-k users (#2491)

b522fd6

* add efficient search logic for large top-k users Signed-off-by: kpango <[email protected]> * fix bug Signed-off-by: kpango <[email protected]> --------- Signed-off-by: kpango <[email protected]>

github-actions bot reviewed May 8, 2024

View reviewed changes

hlts2 closed this May 8, 2024

hlts2 deleted the backport/release/v1.7/feature/gateway-lb/add-efficient-search-for-large-topk-query branch May 8, 2024 07:35

github-actions bot mentioned this pull request Jun 1, 2024

Monthly review time metrics report: 2024-05-01..2024-05-31 #2510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport PR #2491 to release/v1.7 for Add efficient search logic for large top-k users #2494

Backport PR #2491 to release/v1.7 for Add efficient search logic for large top-k users #2494

vdaas-ci commented May 8, 2024

cloudflare-workers-and-pages bot commented May 8, 2024 •

edited

Loading

coderabbitai bot commented May 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

vdaas-ci commented May 8, 2024

vdaas-ci commented May 8, 2024

github-actions bot May 8, 2024

github-actions bot May 8, 2024

Backport PR #2491 to release/v1.7 for Add efficient search logic for large top-k users #2494

Backport PR #2491 to release/v1.7 for Add efficient search logic for large top-k users #2494

Conversation

vdaas-ci commented May 8, 2024

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

cloudflare-workers-and-pages bot commented May 8, 2024 • edited Loading

Deploying vald with Cloudflare Pages

coderabbitai bot commented May 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

vdaas-ci commented May 8, 2024

vdaas-ci commented May 8, 2024

github-actions bot May 8, 2024

Choose a reason for hiding this comment

github-actions bot May 8, 2024

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented May 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)