Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2462 to release/v1.7 for Refactor k8s types #2465

Merged

Refactor k8s types (#2462)

cedc3a7
Select commit
Loading
Failed to load commit list.
Merged

Backport PR #2462 to release/v1.7 for Refactor k8s types #2465

Refactor k8s types (#2462)
cedc3a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 22, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 44.04762% with 47 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/v1.7@1869f98). Click here to learn what that means.

Files Patch % Lines
...kg/index/job/readreplica/rotate/service/rotator.go 10.71% 25 Missing ⚠️
internal/test/mock/k8s/client.go 22.22% 7 Missing ⚠️
internal/k8s/client/client.go 0.00% 5 Missing ⚠️
internal/k8s/job/job.go 0.00% 3 Missing ⚠️
pkg/index/operator/service/operator.go 81.25% 3 Missing ⚠️
pkg/tools/benchmark/operator/service/operator.go 80.00% 2 Missing ⚠️
internal/k8s/job/option.go 0.00% 1 Missing ⚠️
...rnal/k8s/vald/benchmark/job/job_template_option.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.7    #2465   +/-   ##
===============================================
  Coverage                ?   18.89%           
===============================================
  Files                   ?      562           
  Lines                   ?    64595           
  Branches                ?        0           
===============================================
  Hits                    ?    12208           
  Misses                  ?    51592           
  Partials                ?      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.