Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix go binary execution for format and crd #2348

Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Feb 14, 2024

Description

As titled

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: hlts2 <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e786d9
Status: ✅  Deploy successful!
Preview URL: https://e216e8a9.vald.pages.dev
Branch Preview URL: https://ci-format-use-go-build-binar.vald.pages.dev

View logs

@hlts2 hlts2 marked this pull request as ready for review February 14, 2024 04:52
@hlts2 hlts2 self-assigned this Feb 14, 2024
@hlts2 hlts2 changed the title [DO NOT MERGE]: use go build binary for format Bugfix go binary execution for format and crd Feb 14, 2024
@hlts2 hlts2 merged commit f9594df into bugfix/docker/gcc-environment-for-arm Feb 14, 2024
37 of 41 checks passed
@hlts2 hlts2 deleted the ci/format/use-go-build-binary branch February 14, 2024 04:59
kpango pushed a commit that referenced this pull request Feb 14, 2024
* fix: use go build binary to add license

Signed-off-by: hlts2 <[email protected]>

* fix: add debug log

Signed-off-by: hlts2 <[email protected]>

* fix: tweak

Signed-off-by: hlts2 <[email protected]>

* fix: debug log

Signed-off-by: hlts2 <[email protected]>

* fix: tweak

Signed-off-by: hlts2 <[email protected]>

* fix: use local variable

Signed-off-by: hlts2 <[email protected]>

* Revert "fix: use local variable"

This reverts commit 5b1a2e9.

* fix: tweak

Signed-off-by: hlts2 <[email protected]>

* fix: bugfix local variable

Signed-off-by: hlts2 <[email protected]>

* fix: make helm/schema/all format

Signed-off-by: hlts2 <[email protected]>

* fix: revert ci container image tag

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Feb 14, 2024
Fix format-diff error problem (#2345)
Merge branch 'main' into bugfix/docker/gcc-environment-for-arm
fix: warning message for diff
Bugfix go binary execution for format and crd (#2348)
fix: checkout cargo.lock file
Bugfix go binary execution for format and crd (#2348)

Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Feb 14, 2024
… Merge branch 'main' into bugfix/docker/gcc-environment-for-arm fix: warning message for diff Bugfix go binary execution for format and crd (#2348) fix: checkout cargo.lock file Bugfix go binary execution for format and crd (#2348)

Fix setup-helm version (#2349)

Signed-off-by: kpango <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants