New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE]: Investigate k3d problem #2315

Closed

hlts2 wants to merge 21 commits into refactor/internal-o11y/update-otel from investigate/ci/k3d-problem

Collaborator

hlts2 commented Feb 1, 2024

Description:

As titled

Related Issue:

Versions:

Go Version: 1.21.5
Docker Version: 20.10.8
Kubernetes Version: v1.28.4
NGT Version: 2.1.6

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

kpango and others added 2 commits

January 31, 2024 14:33


          refactor update opentelemetry-go & faiss

50ec9de

Signed-off-by: kpango <[email protected]>


          fix: add debug code

b7f93a7

Signed-off-by: hlts2 <[email protected]>

Collaborator

vdaas-ci commented Feb 1, 2024

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions bot added type/ci size/XXXL priority/low labels


          fix: delete path rule of ci

b750030

Signed-off-by: hlts2 <[email protected]>

cloudflare-workers-and-pages bot commented Feb 1, 2024 •

edited

Loading

Deploying with Cloudflare Pages

Latest commit:	`332cddf`
Status:	✅ Deploy successful!
Preview URL:	https://9224245c.vald.pages.dev
Branch Preview URL:	https://investigate-ci-k3d-problem.vald.pages.dev

hlts2 and others added 11 commits

February 1, 2024 12:31


          fix: delete container

0c8c2c9

Signed-off-by: hlts2 <[email protected]>


          fix: add volume section

bf07eef

Signed-off-by: hlts2 <[email protected]>


          fix: add sleep

2f2a262

Signed-off-by: hlts2 <[email protected]>


          fix: add port

a0c19a9

Signed-off-by: hlts2 <[email protected]>


          fix: ci-container image

8d45dd9

Signed-off-by: hlts2 <[email protected]>


          fix: ci-container image

8ccfb82

Signed-off-by: hlts2 <[email protected]>


          fix: ci-container image

96cac63

Signed-off-by: hlts2 <[email protected]>


          fix: delete sleep

feffbbc

Signed-off-by: hlts2 <[email protected]>


          fix: add network

11e58a4

Signed-off-by: hlts2 <[email protected]>


          fix: bridge network

7336c8e

Signed-off-by: hlts2 <[email protected]>


          refactor update opentelemetry-go & faiss

3d252c1

Signed-off-by: kpango <[email protected]>

kpango force-pushed the refactor/internal-o11y/update-otel branch from 50ec9de to 3d252c1 Compare

February 1, 2024 06:08

github-actions bot reviewed

View reviewed changes

docs/tutorial/get-started-with-faiss-agent.md

+                 gateway:
+                   lb:
+                     ...
+                     ingress:

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Ingress
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                     ingress:
+                       enabled: true
+                       # TODO: Set your ingress host.
+                       host: localhost

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Host
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                       # TODO: Set your ingress host.
+                       host: localhost
+                       # TODO: Set annotations which you have to set for your k8s cluster.
+                       annotations:

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Annotations
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                 Deploy vald on your Kubernetes cluster.
+                 ```bash
+                 helm install vald vald/vald --values example/helm/values.yaml

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

docs/tutorial/get-started-with-faiss-agent.md

+                  <details><summary>The detailed explanation of example code is here</summary><br>
+                  This will execute 6 steps.
+.  init

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Init
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                          <details><summary>example code</summary><br>
+                        ```go
+                        for i := range ids [:insertCount] {

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                        for i := range ids [:insertCount] {
+                            _, err := client.Insert(ctx, &payload.Insert_Request{
+                                Vector: &payload.Object_Vector{
+                                    Id:     ids[i],

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                                glg.Fatal(err)
+                            }
+                            b, _ := json.MarshalIndent(res.GetResults(), "", " ")

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: B
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                          <details><summary>example code</summary><br>
+                        ```go
+                        for i := range ids [:insertCount] {

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                        for i := range ids [:insertCount] {
+                            _, err := client.Remove(ctx, &payload.Remove_Request{
+                                Id: &payload.Object_ID{
+                                    Id: ids[i],

Contributor

github-actions bot Feb 1, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

hlts2 added 7 commits

February 1, 2024 15:33


          fix: network host

128f16d

Signed-off-by: hlts2 <[email protected]>


          Merge branch 'refactor/internal-o11y/update-otel' into investigate/ci…

e782574

…/k3d-problem


          fix: use external actions

ba15641

Signed-off-by: hlts2 <[email protected]>


          fix: port settings

c8c7f0f

Signed-off-by: hlts2 <[email protected]>


          fix: port settings

158ef1f

Signed-off-by: hlts2 <[email protected]>


          fix: add option

6bfb524

Signed-off-by: hlts2 <[email protected]>


          fix: delete unused code

332cddf

Signed-off-by: hlts2 <[email protected]>

kpango force-pushed the refactor/internal-o11y/update-otel branch from 3d252c1 to 8c9a045 Compare

February 1, 2024 10:29

hlts2 closed this

hlts2 deleted the investigate/ci/k3d-problem branch

February 1, 2024 11:23

This was referenced Mar 1, 2024

Monthly review time metrics report: 2024-02-01..2024-02-29 ykadowak/actions-test#11

Closed

Monthly review time metrics report: 2024-02-01..2024-02-29 #2429

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/low size/XXXL type/ci