Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor postAttachCommand #2312

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jan 30, 2024

Description:

SSIA

Also modified logic not to write zsh options twice in .zshrc.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6024d96
Status: ✅  Deploy successful!
Preview URL: https://17d0ece0.vald.pages.dev
Branch Preview URL: https://feature-devcontainer-refacto.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak marked this pull request as ready for review January 30, 2024 04:46
@ykadowak ykadowak requested review from a team, kmrmt and vankichi and removed request for a team January 30, 2024 04:46
@vankichi vankichi merged commit b3958f4 into main Jan 30, 2024
20 of 21 checks passed
@vankichi vankichi deleted the feature/devcontainer/refactor-commands branch January 30, 2024 07:32
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants