Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HPA for read replica #2307

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Add HPA for read replica #2307

merged 10 commits into from
Jan 29, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jan 26, 2024

Description:

This PR adds HPA for read replica. Also change the ngt Close logic not try to save index when it's a read replica.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d66fe0
Status: ✅  Deploy successful!
Preview URL: https://c31daec4.vald.pages.dev
Branch Preview URL: https://feature-readreplica-hpa.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15ce01d) 30.21% compared to head (7d66fe0) 30.31%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/agent/core/ngt/usecase/agentd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2307      +/-   ##
==========================================
+ Coverage   30.21%   30.31%   +0.10%     
==========================================
  Files         391      391              
  Lines       40927    40945      +18     
==========================================
+ Hits        12366    12413      +47     
+ Misses      27897    27869      -28     
+ Partials      664      663       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the team/set SET team label Jan 26, 2024
@ykadowak ykadowak changed the title [WIP] Feature/readreplica/hpa Add HPA for read replica Jan 29, 2024
@ykadowak ykadowak marked this pull request as ready for review January 29, 2024 03:51
@ykadowak ykadowak requested review from a team, kpango and datelier and removed request for a team January 29, 2024 03:52
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@datelier datelier merged commit 73416fc into main Jan 29, 2024
224 of 226 checks passed
@datelier datelier deleted the feature/readreplica/hpa branch January 29, 2024 07:57
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants