Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search optimization document #2306

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jan 24, 2024

Description:

I have added the search performance tuning guideline document.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

To display mermaid notation on the web, markdown is wrapped in a div tag.
The displayed diagram is the same as below.

flowchart TD
	A[Perform Linear Search API]
  B{Is satisfies?}
  C[Tuning Parameters to improve precision]
  D[Tuning Embedding Models]
	E[Perform Search API]
	F[Tuning Parameters to improve latency]
  A-->B
	B-- Yes -->C
	B-- No -->D
	C--> E
	E--> C
	E--> F
	F--> E
Loading

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f6158c
Status: ✅  Deploy successful!
Preview URL: https://91dabcbc.vald.pages.dev
Branch Preview URL: https://documentation-docs-create-se.vald.pages.dev

View logs

@vankichi vankichi changed the title [WIP] Add search optimization document Add search optimization document Jan 26, 2024
@vankichi vankichi requested review from a team, datelier and ykadowak and removed request for a team January 26, 2024 07:31
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Comment on lines 12 to 18
<div class="mermaid">
flowchart TD
A[Perform Linear Search API]
B{Is satisfies?}
C[Tuning Parameters to improve precision]
D[Tuning Embedding Models]
E[Perform Search API]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider this style so that the diagram displays on GitHub as well?
https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykadowak could you please check the special note in the PR description? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means it won't be displayed on GitHub right? But sometimes you look at the documents on GitHub directly.

Can we use magefile to replace ```mermaid with <div>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykadowak
the current format can not show correctly on the GitHub.
I will try your suggestion and consider create image instead of mermaid if it won't show as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykadowak
I have fixed the HUGO theme for the Vald website.
vdaas/web#158

ykadowak
ykadowak previously approved these changes Jan 29, 2024
datelier
datelier previously approved these changes Jan 29, 2024
@vankichi vankichi changed the title Add search optimization document [WIP] Add search optimization document Jan 29, 2024
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
@vankichi vankichi dismissed stale reviews from datelier and ykadowak via 0f6158c January 29, 2024 13:47
@vankichi vankichi force-pushed the documentation/docs/create-search-optimization-document branch from 89f03c5 to 0f6158c Compare January 29, 2024 13:47
@vankichi vankichi changed the title [WIP] Add search optimization document Add search optimization document Jan 29, 2024
@vankichi vankichi requested review from datelier and ykadowak January 29, 2024 13:47
@datelier datelier merged commit 6c41eac into main Jan 30, 2024
20 of 21 checks passed
@datelier datelier deleted the documentation/docs/create-search-optimization-document branch January 30, 2024 05:00
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants