Add E2E tests for read replica feature #2298

ykadowak · 2024-01-19T02:25:15Z

Description:

This PR adds E2E for read replica as TestE2EReadReplica.

Add minikube as e2e env because read replica needs ROX policy that k3d does not support.
Update some e2e k8s client helper
Implement the e2e test logic
- deploy vald and vald-readreplica -> insert -> save index -> rotate read replica -> search

Related Issue:

Versions:

Go Version: 1.21.5
Docker Version: 20.10.8
Kubernetes Version: v1.28.4
NGT Version: 2.1.6

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

cloudflare-workers-and-pages · 2024-01-19T02:25:18Z

Deploying with Cloudflare Pages

Latest commit:	`0df5a99`
Status:	✅ Deploy successful!
Preview URL:	https://ae66e4d7.vald.pages.dev
Branch Preview URL:	https://feature-readreplica-e2e.vald.pages.dev

View logs

vdaas-ci · 2024-01-19T02:25:39Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci · 2024-01-19T02:25:49Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

internal/client/v1/client/discoverer/discover_test.go

codecov · 2024-01-19T02:32:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e25aba1) 30.15% compared to head (0df5a99) 30.14%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
- Coverage   30.15%   30.14%   -0.02%     
==========================================
  Files         389      389              
  Lines       40826    40826              
==========================================
- Hits        12313    12307       -6     
- Misses      27861    27867       +6     
  Partials      652      652

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hlts2 · 2024-01-22T08:18:04Z

tests/e2e/crud/crud_test.go

@@ -104,14 +106,12 @@ func init() {
 	flag.Parse()

 	var err error
+	kubeClient, err = client.New(*kubeConfig)


In this case, is it necessary that the environment in which the test is run always have information about the connection to the Kubernetes cluster? 🤔

Yes.

TestE2EReadReplica needs to be dependent on k8s client anyway so I guess I should revert this and check this in TestE2EReadReplica? That way other e2e tests can run without k8s clinet.

I fixed that way ed4e8b3 since I think it's better anyway.

Let me know if this is not what you intended.

so I guess I should revert this and check this in TestE2EReadReplica?

Thank you for reply 🙏
Yes, I think that would be better!!

I reviewed your changes! It looks good to me! 🙏
Thank you 🙏

vankichi · 2024-01-22T08:32:07Z

I will LGTM if the above conversation has been resolved

This commit fixes the style issues introduced in d127dbc according to the output from Gofumpt and Prettier. Details: #2298

hlts2

LGTM!

github-actions bot added team/set SET team team/sre SRE team area/internal type/ci area/helm area/gateway/lb labels Jan 19, 2024

github-actions bot added size/L type/feature New feature labels Jan 19, 2024

ykadowak added the actions/e2e-deploy label Jan 19, 2024

github-actions bot added the priority/medium label Jan 19, 2024

github-actions bot reviewed Jan 19, 2024

View reviewed changes

ykadowak force-pushed the feature/readreplica/e2e branch from 6573794 to 29f2a3c Compare January 19, 2024 05:52

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 19, 2024

ykadowak force-pushed the feature/readreplica/e2e branch from 29f2a3c to bebca21 Compare January 19, 2024 05:58

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 19, 2024

ykadowak force-pushed the feature/readreplica/e2e branch from bebca21 to a5d03e1 Compare January 19, 2024 06:09

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 19, 2024

ykadowak force-pushed the feature/readreplica/e2e branch from a5d03e1 to 6bc8021 Compare January 19, 2024 06:10

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 19, 2024

ykadowak force-pushed the feature/readreplica/e2e branch from 6bc8021 to 3c3aa41 Compare January 19, 2024 06:28

Apply format

67f6eed

github-actions bot added size/L and removed size/L labels Jan 22, 2024

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 22, 2024

ykadowak changed the title ~~[WIP] Feature/readreplica/e2e~~ Add E2E tests for read replica feature Jan 22, 2024

ykadowak marked this pull request as ready for review January 22, 2024 07:46

ykadowak requested review from a team, vankichi and hlts2 and removed request for a team January 22, 2024 07:47

hlts2 reviewed Jan 22, 2024

View reviewed changes

ykadowak and others added 3 commits January 22, 2024 08:48

Seperate k8s client initialization in TestE2EReadReplica

ed4e8b3

Fix comment

d127dbc

style: format code with Gofumpt and Prettier

0df5a99

This commit fixes the style issues introduced in d127dbc according to the output from Gofumpt and Prettier. Details: #2298

github-actions bot added size/L and removed size/L labels Jan 22, 2024

ykadowak requested a review from hlts2 January 22, 2024 08:49

ykadowak added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 22, 2024

hlts2 approved these changes Jan 22, 2024

View reviewed changes

vankichi approved these changes Jan 22, 2024

View reviewed changes

vankichi merged commit 2ca7187 into main Jan 22, 2024
71 of 73 checks passed

vankichi deleted the feature/readreplica/e2e branch January 22, 2024 10:39

This was referenced Jan 28, 2024

Monthly issue metrics report ykadowak/actions-test#8

Open

Monthly review time metrics report: 2024-01-01..2024-01-31 ykadowak/actions-test#10

Closed

Monthly review time metrics report: 2024-01-01..2024-01-31 #2314

Closed

This was referenced Feb 15, 2024

[patch] Release v1.7.11 #2355

Merged

[patch] Release v1.7.11 #2358

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add E2E tests for read replica feature #2298

Add E2E tests for read replica feature #2298

ykadowak commented Jan 19, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 19, 2024 •

edited

Loading

vdaas-ci commented Jan 19, 2024

vdaas-ci commented Jan 19, 2024

codecov bot commented Jan 19, 2024 •

edited

Loading

hlts2 Jan 22, 2024

ykadowak Jan 22, 2024

ykadowak Jan 22, 2024

hlts2 Jan 22, 2024

hlts2 Jan 22, 2024

vankichi commented Jan 22, 2024

hlts2 left a comment

Add E2E tests for read replica feature #2298

Add E2E tests for read replica feature #2298

Conversation

ykadowak commented Jan 19, 2024 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

cloudflare-workers-and-pages bot commented Jan 19, 2024 • edited Loading

Deploying with Cloudflare Pages

vdaas-ci commented Jan 19, 2024

vdaas-ci commented Jan 19, 2024

codecov bot commented Jan 19, 2024 • edited Loading

Codecov Report

hlts2 Jan 22, 2024

Choose a reason for hiding this comment

ykadowak Jan 22, 2024

Choose a reason for hiding this comment

ykadowak Jan 22, 2024

Choose a reason for hiding this comment

hlts2 Jan 22, 2024

Choose a reason for hiding this comment

hlts2 Jan 22, 2024

Choose a reason for hiding this comment

vankichi commented Jan 22, 2024

hlts2 left a comment

Choose a reason for hiding this comment

ykadowak commented Jan 19, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 19, 2024 •

edited

Loading

codecov bot commented Jan 19, 2024 •

edited

Loading