Add Filter query configuration to Continuous Benchmark Job #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
|
[CHATOPS:HELP] ChatOps commands.
|
|
[WARNING:INTCFG] Changes in |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <[email protected]>
Deploying with
|
| Latest commit: |
0e6b740
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9aa83f1c.vald.pages.dev |
| Branch Preview URL: | https://fix-filter-build-error.vald.pages.dev |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/egress-gateway/add-egress-query #2296 +/- ##
===========================================================================
- Coverage 30.28% 30.26% -0.02%
===========================================================================
Files 378 378
Lines 37242 37255 +13
===========================================================================
- Hits 11277 11275 -2
- Misses 25407 25422 +15
Partials 558 558 ☔ View full report in Codecov by Sentry. |
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/fix%2Ffilter%2Fbuild-error/29c5848bd41fc46586ed17bcb5976346dadf3fbb |
Profile Report
|
hlts2
requested review from
vankichi,
a team and
kmrmt
and removed request for
a team
kmrmt
merged commit 16c25cd
into
feature/egress-gateway/add-egress-query
224 of 228 checks passed
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WHY
In the following PR, we made a change to pass a query to
FilterConfig.This caused a build error of the Continuous Benchmark Job, but I fixed it in this PR.
WHAT
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: