Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isSymlink function to correctly check for symbolic links #2292

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix isSymlink function to correctly check for symbolic links #2292

merged 2 commits into from
Jan 11, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jan 11, 2024 •
edited
Loading

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak marked this pull request as ready for review January 11, 2024 04:47
@ykadowak ykadowak requested review from a team, kpango and datelier and removed request for a team January 11, 2024 04:47
kpango
kpango approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 11, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e61ea3
Status: ✅  Deploy successful!
Preview URL: https://01e60afa.vald.pages.dev
Branch Preview URL: https://fix-license-ignore-symlink-2.vald.pages.dev

View logs

@ykadowak ykadowak merged commit 9be659b into main Jan 11, 2024
25 of 26 checks passed
@ykadowak ykadowak deleted the fix/license/ignore-symlink-2 branch January 11, 2024 06:01
This was referenced Jan 28, 2024
Open
Closed
Closed
This was referenced Feb 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datelier datelier datelier approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
priority/low size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @datelier