Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug/readreplica/grpc connection #2288

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 9, 2024

Description:

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jan 9, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added size/L type/bug Something isn't working labels Jan 9, 2024
@kpango kpango force-pushed the debug/readreplica/grpc-connection branch from 83b20be to 180cae5 Compare January 9, 2024 05:28
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 180cae5
Status: ✅  Deploy successful!
Preview URL: https://63954ed8.vald.pages.dev
Branch Preview URL: https://debug-readreplica-grpc-conne.vald.pages.dev

View logs

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (7407cba) 29.91% compared to head (180cae5) 29.90%.

Files Patch % Lines
internal/net/grpc/client.go 0.00% 15 Missing ⚠️
internal/net/grpc/pool/pool.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/readreplica/client    #2288      +/-   ##
==============================================================
- Coverage                       29.91%   29.90%   -0.01%     
==============================================================
  Files                             371      371              
  Lines                           36219    36232      +13     
==============================================================
+ Hits                            10834    10835       +1     
- Misses                          24870    24882      +12     
  Partials                          515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpango kpango changed the title [WIP] Debug/readreplica/grpc connection debug/readreplica/grpc connection Jan 9, 2024
@ykadowak ykadowak merged commit b07d03c into feature/readreplica/client Jan 9, 2024
93 of 97 checks passed
@ykadowak ykadowak deleted the debug/readreplica/grpc-connection branch January 9, 2024 06:05
@kpango kpango restored the debug/readreplica/grpc-connection branch January 10, 2024 05:04
@kpango kpango deleted the debug/readreplica/grpc-connection branch January 10, 2024 05:05
ykadowak pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants