Separate readreplica chart #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fb57e83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a218fa9e.vald.pages.dev |
| Branch Preview URL: | https://feature-readreplica-separate-fpaj.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/helm
size/S
type/feature
ykadowak
force-pushed
the
feature/readreplica/separate-helm-2
branch
from
5c1c80f to
5568efb
Compare
|
/format |
|
[FORMAT] Failed to format. |
|
Could you please add README.md? and values.schema.json too |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kpango
reviewed
Jan 5, 2024
charts/vald-readreplica/README.md
Outdated
|
|
||
| ### Overview | ||
|
|
||
| `values.yaml` is a symbolic link to the `values.yaml` of the main vald chart |
There was a problem hiding this comment.
can you add the link to each file ?
vankichi
requested changes
Jan 5, 2024
Co-authored-by: Kiichiro YUKAWA <[email protected]>
vankichi
previously approved these changes
Jan 5, 2024
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR separates the read replica related resources into a separate chart and removes them from under helm operator management. The reason for this is that the rotator's process to restart those resources conflicts with the helm operator.
The
values.yamlof vald-read-replica chart is a symlink to the originalvalues.yamland it'll be copied automatically when packaging byhelm package.The deployment procedure for the read replica resources in an operator environment will be as follows:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: