-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker buildx cache #2261
Merged
Merged
Add docker buildx cache #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/sre
SRE team
area/makefile
size/L
type/refactoring
priority/low
labels
Dec 6, 2023
Deploying with Cloudflare Pages
|
kpango
requested review from
a team,
vankichi and
datelier
and removed request for
a team
December 6, 2023 21:53
kpango
commented
Dec 6, 2023
kpango
force-pushed
the
refactor/makefile-ci/add-docker-buildx-cache
branch
5 times, most recently
from
December 6, 2023 23:27
c70d4c1
to
0235226
Compare
kpango
force-pushed
the
refactor/makefile-ci/add-docker-buildx-cache
branch
from
December 6, 2023 23:34
0235226
to
93ed8bb
Compare
vankichi
previously approved these changes
Dec 7, 2023
hlts2
previously approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 💯
kpango
force-pushed
the
refactor/makefile-ci/add-docker-buildx-cache
branch
2 times, most recently
from
December 7, 2023 05:16
63bac23
to
b79d097
Compare
vankichi
previously approved these changes
Dec 7, 2023
Signed-off-by: kpango <[email protected]>
kpango
force-pushed
the
refactor/makefile-ci/add-docker-buildx-cache
branch
from
December 7, 2023 06:07
b79d097
to
35f7e84
Compare
vankichi
approved these changes
Dec 7, 2023
hlts2
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: kpango <[email protected]>
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've added Docker buildkit registry cache for vald docker image builds.
and compress each docker image with zstd for more efficient start up performance.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: