Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #2260

Merged
merged 3 commits into from
Dec 6, 2023
Merged

update dependencies #2260

merged 3 commits into from
Dec 6, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 4, 2023

Description:

This PR includes 3 changes.

  1. Update Go Version v1.21.4 to v1.21.5
  2. Update go module dependencies
  3. Re-Generate test files. (Just generated by Makefile, please ignore test files for this PR review.)

Related Issue:

Versions:

  • Go Version: 1.21.4
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 4, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (405e499) 30.23% compared to head (c6ce32b) 29.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   30.23%   29.99%   -0.25%     
==========================================
  Files         362      370       +8     
  Lines       35772    36085     +313     
==========================================
+ Hits        10817    10824       +7     
- Misses      24441    24747     +306     
  Partials      514      514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 4, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Signed-off-by: kpango <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6ce32b
Status: ✅  Deploy successful!
Preview URL: https://f02b93a2.vald.pages.dev
Branch Preview URL: https://update-deps.vald.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Dec 5, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 5, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Signed-off-by: kpango <[email protected]>
// }
// type test struct {
// name string
// args args
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (args) found (dupword)

@ykadowak ykadowak self-requested a review December 6, 2023 02:03
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpango kpango merged commit 9cd436e into main Dec 6, 2023
105 of 109 checks passed
@kpango kpango deleted the update/deps branch December 6, 2023 02:04
@kpango kpango mentioned this pull request Dec 6, 2023
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
* update dependencies

Signed-off-by: kpango <[email protected]>

* re-generate test

Signed-off-by: kpango <[email protected]>

* fix test generation for main package

Signed-off-by: kpango <[email protected]>

---------

Signed-off-by: kpango <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants