-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent readreplica resources #2258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykadowak
changed the title
[WIP] Feature/readreplica/deployments
Add agent readreplica resources
Dec 7, 2023
ykadowak
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
December 7, 2023 02:34
hlts2
previously approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kmrmt
previously approved these changes
Dec 7, 2023
hlts2
approved these changes
Dec 7, 2023
kmrmt
approved these changes
Dec 7, 2023
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Implement sample read replica rotation logic * Add external-snapshotter in go.mod * Add readreplica initial implementation * Add service implementation of readreplica rotator * Add readreplica rotate config * Refactor to read labels * replace id to _MY_TARGET_REPLICA_ID_ * Add snapshot k8s client * Format * Fix snapshot client initialization * Add Apache License to main.go * Use GetConfigOrDie * Use internal/k8s client * Refactor * Use controller-runtime for CRUD in readreplica * Remove snapshot client and use controller-runtime * Move LabelSelector into internal/k8s * Report error to span * Update go modules * Remove old example * Refactor * Disable exhaustruct for now * Fix predeclared * Fix stylecheck * nolint:gomnd * Add test template * Add test for getNewBaseName * Add readreplica-rotate build scripts * Add service account and clusterroles for read replica rotator * Update charts * Update comment * Add readreplica deployment templates * Add readreplica deployment template * Add svc for readreplica * Update valdrelease * Add podAntiAffinity for readreplica * Add security context for readreplica * Update valdrelease * Update valdrelease scheme * Fix component name of readreplica so that svc can find it well * Change readreplica svc component name * Change headless to normal ClusterIP to do loadbalancing for readreplica * Fix comment * Parametarize some field in configmap * remove sidecar related things from readreplica deployment * Fix readreplica svc type to ClusterIP * Update README.md * Add networkpolicy * Update docs * Update network policy selector label * Apply format
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds k8s resources related to
readreplica
feature. Also addedsecurityContext
and refactor configmap of readreplica rotator.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: