-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert vtpool for ResourceExhausted problem #2255
Conversation
[CHATOPS:HELP] ChatOps commands.
|
|
||
### Help | ||
|
||
Provides links to documentation or for performing an out of band action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
Did you mean “out-of-band”? (OUT_OF_PLACE[1])
Suggestions: out-of-band
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/OUT_OF_PLACE?lang=en-US&subId=1
Category: PUNCTUATION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
- Coverage 30.50% 30.42% -0.09%
==========================================
Files 362 362
Lines 35376 35443 +67
==========================================
- Hits 10792 10784 -8
- Misses 24073 24146 +73
- Partials 511 513 +2 ☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
44eab63
to
2d2d961
Compare
Signed-off-by: kpango <[email protected]>
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/revert%2Fvtpool/600004d367291ab3dc80a2c509528fd425535788 |
Profile Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM 👍
* revert vtpool Signed-off-by: kpango <[email protected]> * Fix documentation --------- Signed-off-by: kpango <[email protected]> Co-authored-by: ykadowak <[email protected]>
* revert vtpool Signed-off-by: kpango <[email protected]> * Fix documentation --------- Signed-off-by: kpango <[email protected]> Co-authored-by: ykadowak <[email protected]>
Description:
This PR reverts #2173 because it contained a regression that caused
RESOURCE_EXHAUSTED
error when upserting from the Python Client.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: